Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source zendesk support: validate datetime on check #24252

Merged

Conversation

davydov-d
Copy link
Collaborator

What

https://github.com/airbytehq/oncall/issues/1683

How

Add validation of a start_date param when checking connectivity

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support labels Mar 20, 2023
@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 20, 2023

/test connector=connectors/source-zendesk-support

🕑 connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4472284002
✅ connectors/source-zendesk-support https://github.com/airbytehq/airbyte/actions/runs/4472284002
Python tests coverage:

Name                                                           Stmts   Miss  Cover
----------------------------------------------------------------------------------
source_zendesk_support/__init__.py                                 2      0   100%
source_zendesk_support/streams.py                                399     39    90%
source_zendesk_support/source.py                                  57      6    89%
source_zendesk_support/ZendeskSupportAvailabilityStrategy.py      10      6    40%
----------------------------------------------------------------------------------
TOTAL                                                            468     51    89%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:509: The previous and actual discovered catalogs are identical.
================== 44 passed, 3 skipped in 734.21s (0:12:14) ===================

@davydov-d davydov-d requested review from bnchrch and lazebnyi March 20, 2023 19:49
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. 👍

One comment I do think we should address.

I will approve so as not to be a blocker.

@davydov-d
Copy link
Collaborator Author

davydov-d commented Mar 21, 2023

/publish connector=connectors/source-zendesk-support

🕑 Publishing the following connectors:
connectors/source-zendesk-support
https://github.com/airbytehq/airbyte/actions/runs/4476504714


Connector Did it publish? Were definitions generated?
connectors/source-zendesk-support

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@davydov-d davydov-d merged commit 6c434c8 into master Mar 21, 2023
@davydov-d davydov-d deleted the ddavydov/#1683-source-zendesk-support-validate-dt-on-check branch March 21, 2023 08:48
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1683 source zendesk support: validate datetime on check

* #1683 source zendesk support: upd changelog

* Automated Change

* rm extra files

* auto-bump connector version

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
* #1683 source zendesk support: validate datetime on check

* #1683 source zendesk support: upd changelog

* Automated Change

* rm extra files

* auto-bump connector version

---------

Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants