-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source zendesk support: validate datetime on check #24252
Source zendesk support: validate datetime on check #24252
Conversation
/test connector=connectors/source-zendesk-support
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. 👍
One comment I do think we should address.
I will approve so as not to be a blocker.
airbyte-integrations/connectors/source-zendesk-support/source_zendesk_support/source.py
Show resolved
Hide resolved
/publish connector=connectors/source-zendesk-support
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* #1683 source zendesk support: validate datetime on check * #1683 source zendesk support: upd changelog * Automated Change * rm extra files * auto-bump connector version --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
* #1683 source zendesk support: validate datetime on check * #1683 source zendesk support: upd changelog * Automated Change * rm extra files * auto-bump connector version --------- Co-authored-by: davydov-d <davydov-d@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
https://github.com/airbytehq/oncall/issues/1683
How
Add validation of a
start_date
param when checking connectivity