Source Quickbooks: migrate to low-code #24324

roman-yermilov-gl · 2023-03-21T17:06:18Z

What

Migrate QuickBooks Singer to Low-Code

airbyte-integrations/connectors/source-quickbooks/acceptance-test-config.yml

airbyte-integrations/connectors/source-quickbooks/integration_tests/abnormal_state.json

airbyte-integrations/connectors/source-quickbooks/acceptance-test-config.yml

lazebnyi

LGTM

…-code

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

…cator

…-code

davydov-d · 2023-04-05T17:23:29Z

depends on #24891

davydov-d · 2023-04-06T10:37:42Z

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4628030091
✅ connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4628030091
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_quickbooks/__init__.py         3      0   100%
source_quickbooks/components.py      36      4    89%
source_quickbooks/source.py           4      1    75%
-----------------------------------------------------
TOTAL                                43      5    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
================== 38 passed, 2 skipped in 368.57s (0:06:08) ===================

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

docs/integrations/sources/quickbooks.md

…-code

airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml

docs/integrations/sources/quickbooks.md

airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml

airbyte-integrations/connectors/source-quickbooks/source_quickbooks/components.py

docs/integrations/sources/quickbooks.md

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

davydov-d · 2023-04-10T11:36:59Z

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4657087094

davydov-d · 2023-04-10T11:46:38Z

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4657135511
❌ connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4657135511
🐛

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
================== 38 passed, 2 skipped in 376.21s (0:06:16) ===================

davydov-d · 2023-04-10T17:36:40Z

@sherifnada please take a look once more

davydov-d · 2023-04-10T18:13:30Z

/test connector=connectors/source-quickbooks

🕑 connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4660000964
✅ connectors/source-quickbooks https://github.com/airbytehq/airbyte/actions/runs/4660000964
Python tests coverage:

Name                              Stmts   Miss  Cover
-----------------------------------------------------
source_quickbooks/__init__.py         3      0   100%
source_quickbooks/components.py      36      4    89%
source_quickbooks/source.py           4      1    75%
-----------------------------------------------------
TOTAL                                43      5    88%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:103: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:581: The previous connector image could not be retrieved.
================== 38 passed, 2 skipped in 374.96s (0:06:14) ===================

davydov-d · 2023-04-10T19:05:47Z

/publish connector=connectors/source-quickbooks

🕑 Publishing the following connectors:
connectors/source-quickbooks
https://github.com/airbytehq/airbyte/actions/runs/4660393356

Connector	Did it publish?	Were definitions generated?
connectors/source-quickbooks	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Source Quickbooks: migrate to low-code * Source Quickbooks: add oauth flow * airbytehq#24658 Lowcode CDK: implement single use refresh token oauth authenticator * #23498 source Quickbooks: set up CATs * airbytehq#24658 lowcode cdk: review fixes * upd manifest version + airbyte cdk version * delete source-quickbooks-singer along with seed * Automated Change * update docs and spec.json * revert data type map in docs * Automated Change * quickbooks: review fixes * quickbooks: more review fixes * quickbooks: modify spec * quickbooks: rename icon * quickbooks: generate definitions --------- Co-authored-by: Denys Davydov <davydov.den18@gmail.com> Co-authored-by: davydov-d <davydov-d@users.noreply.github.com>

roman-yermilov-gl requested review from grubberr, midavadim, davydov-d, arsenlosenko, bazarnov, artem1205, lazebnyi and darynaishchenko March 21, 2023 17:06

roman-yermilov-gl self-assigned this Mar 21, 2023

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/quickbooks labels Mar 21, 2023

roman-yermilov-gl force-pushed the ryermilov/source-quickbooks-migrate-to-low-code branch 2 times, most recently from 61f0a48 to bbbf586 Compare March 22, 2023 11:16

lazebnyi requested changes Mar 23, 2023

View reviewed changes

roman-yermilov-gl force-pushed the ryermilov/source-quickbooks-migrate-to-low-code branch from bbbf586 to 3b0b02e Compare March 23, 2023 13:14

roman-yermilov-gl requested a review from lazebnyi March 23, 2023 13:15

roman-yermilov-gl force-pushed the ryermilov/source-quickbooks-migrate-to-low-code branch from 3b0b02e to 9eb9bdf Compare March 23, 2023 13:44

roman-yermilov-gl added 2 commits March 23, 2023 17:46

Source Quickbooks: migrate to low-code

9eb9bdf

Source Quickbooks: add oauth flow

c6f8480

lazebnyi approved these changes Mar 27, 2023

View reviewed changes

davydov-d added 3 commits April 4, 2023 11:14

Merge branch 'master' into ryermilov/source-quickbooks-migrate-to-low…

133c1c1

…-code

Merge branch 'ryermilov/source-quickbooks-migrate-to-low-code' of git…

02a3b76

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

#24658 Lowcode CDK: implement single use refresh token oauth authenti…

9fad513

…cator

davydov-d mentioned this pull request Apr 5, 2023

Source Quickbooks Singer: Mark datefields in spec as dates #22902

Closed

37 tasks

davydov-d added 2 commits April 5, 2023 12:55

Merge branch 'master' into ryermilov/source-quickbooks-migrate-to-low…

6d8cdba

…-code

#23498 source Quickbooks: set up CATs

8c5a513

bazarnov approved these changes Apr 5, 2023

View reviewed changes

#24658 lowcode cdk: review fixes

12a30bf

davydov-d requested a review from a team April 6, 2023 10:38

delete source-quickbooks-singer along with seed

26348f1

octavia-squidington-iii added the connectors/source/quickbooks-singer label Apr 6, 2023

davydov-d and others added 3 commits April 6, 2023 11:29

Automated Change

2e44226

update docs and spec.json

b40faaa

Merge branch 'ryermilov/source-quickbooks-migrate-to-low-code' of git…

5725289

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

evantahler reviewed Apr 6, 2023

View reviewed changes

airbyte-config/init/src/main/resources/seed/source_definitions.yaml Outdated Show resolved Hide resolved

evantahler reviewed Apr 6, 2023

View reviewed changes

docs/integrations/sources/quickbooks.md Show resolved Hide resolved

davydov-d and others added 3 commits April 6, 2023 21:34

revert data type map in docs

7196c13

Merge branch 'master' into ryermilov/source-quickbooks-migrate-to-low…

8fd88ec

…-code

Automated Change

6db139e

evantahler reviewed Apr 6, 2023

View reviewed changes

airbyte-config-oss/init-oss/src/main/resources/seed/source_definitions.yaml Outdated Show resolved Hide resolved

sherifnada suggested changes Apr 7, 2023

View reviewed changes

davydov-d added 3 commits April 10, 2023 14:02

quickbooks: review fixes

4084f34

Merge branch 'ryermilov/source-quickbooks-migrate-to-low-code' of git…

c322919

…hub.com:airbytehq/airbyte into ryermilov/source-quickbooks-migrate-to-low-code

quickbooks: more review fixes

d2bc44b

quickbooks: modify spec

44a2484

quickbooks: rename icon

000aa02

davydov-d requested a review from sherifnada April 10, 2023 15:44

sherifnada approved these changes Apr 10, 2023

View reviewed changes

quickbooks: generate definitions

8765423

davydov-d merged commit a992167 into master Apr 11, 2023

davydov-d deleted the ryermilov/source-quickbooks-migrate-to-low-code branch April 11, 2023 05:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Quickbooks: migrate to low-code #24324

Source Quickbooks: migrate to low-code #24324

roman-yermilov-gl commented Mar 21, 2023

lazebnyi left a comment

davydov-d commented Apr 5, 2023

davydov-d commented Apr 6, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

Source Quickbooks: migrate to low-code #24324

Source Quickbooks: migrate to low-code #24324

Conversation

roman-yermilov-gl commented Mar 21, 2023

What

lazebnyi left a comment

Choose a reason for hiding this comment

davydov-d commented Apr 5, 2023

davydov-d commented Apr 6, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Apr 10, 2023 • edited by github-actions bot Loading

davydov-d commented Apr 10, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Apr 10, 2023

davydov-d commented Apr 10, 2023 • edited by github-actions bot Loading

Build Passed

davydov-d commented Apr 10, 2023 • edited by github-actions bot Loading

davydov-d commented Apr 6, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading

davydov-d commented Apr 10, 2023 •

edited by github-actions bot

Loading