-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: streams table #24326
Docs: streams table #24326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have a few comments/edits.
Co-authored-by: Andy Jih <andyjih@users.noreply.github.com>
Co-authored-by: Andy Jih <andyjih@users.noreply.github.com>
@andyjih thanks for taking a look! I committed your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had some minor comments about this. I had a bigger note about how to refer to the primary keys; the user can always select multiple.
@@ -1,94 +1,158 @@ | |||
# Edit stream configuration | |||
# Manage syncs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if manage syncs is a good name for this. We're not managing the syncs here. What was there before makes more sense to me.
|
||
To save the changes: | ||
1. Click **Save changes**, or click **Cancel** to discard the changes. | ||
7. Click the **X** to close the stream details panel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7. Click the **X** to close the stream details panel. | |
7. Click the **X** on the top right to close the stream details panel. |
Co-authored-by: Edmundo Ruiz Ghanem <168664+edmundito@users.noreply.github.com>
edited based on Edmundo's suggestions
Updated docs for the new stream table.
The UI for the new streams table has been updated, so I updated docs to reflect those changes and made new gifs to show the updated UI.