Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type hints for the message grouper #24345

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Mar 22, 2023

What

  • Some methods of the message grouper are missing type hints

Recommended reading order

  1. message_grouper.py

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 22, 2023
@girarda girarda requested a review from brianjlai March 22, 2023 00:56
@girarda girarda marked this pull request as ready for review March 22, 2023 00:56
@girarda girarda requested a review from a team as a code owner March 22, 2023 00:56
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@girarda girarda merged commit aaf00de into master Mar 22, 2023
@girarda girarda deleted the alex/message_grouper_type_hints branch March 22, 2023 14:15
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
erohmensing pushed a commit that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants