Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pattern descriptors to more fields in github and postgres sources #24417

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Mar 23, 2023

What

Add pattern descriptors to the fields in the github and postgres connectors that have expected formats.

This is necessary for us to successfully do an A/B test on if these new features are helpful for improving success rates of users.

Here's how these new specs look in the UI (notice the pattern descriptors displayed to the top-right of the inputs):
Screen Shot 2023-03-23 at 11 39 25 AM
Screen Shot 2023-03-23 at 11 39 36 AM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

  • Run integration tests
  • Bump connector or module version
  • Add changelog
  • Publish the new version

✅ Sources (3)

Connector Version Changelog Publish
source-alloydb 2.0.9
source-alloydb-strict-encrypt 2.0.9 🔵
(ignored)
🔵
(ignored)
source-postgres-strict-encrypt 2.0.10 🔵
(ignored)
🔵
(ignored)
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector Version Changelog Publish
  • See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category Status Actionable Item
Version
mismatch
The version of the connector is different from its normal variant. Please bump the version of the connector.

doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.
Changelog
doc not found
The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like source-jdbc is not published or documented). Please double-check to make sure that it is not a bug.

changelog missing
There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish
not in seed
The connector is not in the seed file (e.g. source_definitions.yaml), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.

diff seed version
The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the /publish command to publish the latest version.

@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/test connector=connectors/source-github

🕑 connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4504101078
✅ connectors/source-github https://github.com/airbytehq/airbyte/actions/runs/4504101078
Python tests coverage:

Name                             Stmts   Miss  Cover
----------------------------------------------------
source_github/utils.py              14      0   100%
source_github/github_schema.py    8807      0   100%
source_github/__init__.py            2      0   100%
source_github/streams.py           854     91    89%
source_github/graphql.py           167     22    87%
source_github/source.py            118     34    71%
----------------------------------------------------
TOTAL                             9962    147    99%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 48 passed, 2 skipped in 365.65s (0:06:05) ===================

@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4504107832
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4504107832
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 70 passed, 3 skipped in 119.68s (0:01:59) ===================

@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4504111287
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4504111287
No Python unittests run

Build Passed

Test summary info:

All Passed

@lmossman lmossman marked this pull request as ready for review March 23, 2023 18:41
@lmossman lmossman requested a review from a team as a code owner March 23, 2023 18:41
@lmossman lmossman requested review from rodireich and flash1293 March 23, 2023 18:42
@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/publish connector=connectors/source-github

🕑 Publishing the following connectors:
connectors/source-github
https://github.com/airbytehq/airbyte/actions/runs/4504946031


Connector Did it publish? Were definitions generated?
connectors/source-github

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/publish connector=connectors/source-postgres

🕑 Publishing the following connectors:
connectors/source-postgres
https://github.com/airbytehq/airbyte/actions/runs/4504951355


Connector Did it publish? Were definitions generated?
connectors/source-postgres

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lmossman
Copy link
Contributor Author

lmossman commented Mar 23, 2023

/publish connector=connectors/source-postgres-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-postgres-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4504986746


Connector Did it publish? Were definitions generated?
connectors/source-postgres-strict-encrypt

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lmossman lmossman merged commit a00edf8 into master Mar 23, 2023
@lmossman lmossman deleted the lmossman/github-postgres-pattern-descriptors branch March 23, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants