🎉 Compare versions tool #24421
Merged
🎉 Compare versions tool #24421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Nice!
✔️ This keeps records in memory
✔️ It compares the output
Some docs might be nice, e.g. a readme or a comment at the top
- Looks like this needs to be run from the root dir of the connector (where /secrets is relatively nearby)
- You probably don't want to run a whole sync, so some thought should be used when choosing a starting state? Or, maybe you do want to run a "full" sync
It also might be helpful to use a visual diff tool. Here are some.
lazebnyi
requested review from
evantahler and
sherifnada
and removed request for
sherifnada
evantahler
approved these changes
Mar 24, 2023
sherifnada
suggested changes
Mar 24, 2023
|
@lazebnyi Please take a look at the latest comments and let's aim to wrap this up on Monday, please 🙏 |
|
@YowanR thanks. It look like I already fixed few day ago) - #24421 (comment) |
sherifnada
approved these changes
Mar 27, 2023
|
Looks like this is ready to be merged! Can we please proceed? @lazebnyi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To compare in memory records outputs need some tool
How
Created a bash script that pull the images for the two docker versions and calculated the difference of the record output