Source Stripe: fix stream slicing

[davydov-d]

What

https://github.com/airbytehq/oncall/issues/1713

How

Refactoring in this PR introduced a bug: some streams yielded None as a slice instead of {}. As a rule we yield a None slice if a start_date is > now() so we dont make request to read the data in the future and pass an abnormally large incremental read test. A check in read_records skips this slice.

This wasn't caught by the CAT because we dont have those streams well seeded (perhaps it's impossible). Now the slicing is fixed.

[davydov-d]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4513064439
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4513064439
🐛 https://gradle.com/s/z4fl5d4u2dijg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 200.97s (0:03:20) ==============

[pedroslopez]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4514775616
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4514775616
🐛 https://gradle.com/s/eotybcd2helgg

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Please check...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 199.56s (0:03:19) ==============

[pedroslopez]

/test connector=connectors/source-stripe

🕑 connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4514850140
❌ connectors/source-stripe https://github.com/airbytehq/airbyte/actions/runs/4514850140
🐛 https://gradle.com/s/zcp2qfsonbzks

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream event...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 200.55s (0:03:20) ==============

[pedroslopez]

Latest failure is due to expected records mismatch, which is happening on master and is a known failure, so publishing anyway for this OC fix.

[pedroslopez]

/publish connector=connectors/source-stripe run-tests=false

🕑 Publishing the following connectors:
connectors/source-stripe
https://github.com/airbytehq/airbyte/actions/runs/4515002025

Connector	Did it publish?	Were definitions generated?
connectors/source-stripe	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️