Set ssl_mode to require on remaining strict encrypt db sources #24529

lmossman · 2023-03-24T21:16:42Z

What

Similar to #24446, this PR sets the SSL Mode field to required on the remaining strict encrypt db sources that have that field.

How

Set the SSL Mode default field to require/required in the strict encrypt classes' modifySpec method.

Note: to update alloydb, I had to modify the PostgresStrictEncryptSource file in the source-postgres directory, since that is what AlloyDb strict encrypt is currently pulling from.
This update was not made in the above linked PR, because there are currently two PostgresStrictEncryptSource files: one in the source-postgres folder which is only used for integration tests and for the alloydb strict encrypt connector, and one in the source-postgres-strict-encrypt folder which is actually the one used to build the postgres strict encrypt docker image (and that is the one I updated in the above linked PR).

These duplicate files should be consolidated, as discussed on slack here and captured in this issue

github-actions · 2023-03-24T21:20:04Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (5)

Connector	Version	Changelog	Publish
`source-alloydb`	`2.0.10`	✅	✅
`source-alloydb-strict-encrypt`	`2.0.10`	🔵 (ignored)	🔵 (ignored)
`source-mysql`	`2.0.9`	✅	✅
`source-mysql-strict-encrypt`	`2.0.9`	🔵 (ignored)	🔵 (ignored)
`source-postgres-strict-encrypt`	`2.0.11`	🔵 (ignored)	🔵 (ignored)

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

✅ Other Modules (0)

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

lmossman · 2023-03-24T21:26:11Z

/test connector=connectors/source-alloydb

🕑 connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/4515494384
✅ connectors/source-alloydb https://github.com/airbytehq/airbyte/actions/runs/4515494384
No Python unittests run

Build Passed

Test summary info:

All Passed

lmossman · 2023-03-24T21:26:27Z

/test connector=connectors/source-alloydb-strict-encrypt

🕑 connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4515495617
✅ connectors/source-alloydb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4515495617
No Python unittests run

Build Passed

Test summary info:

All Passed

lmossman · 2023-03-24T21:26:44Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4515497045
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/4515497045
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestConnection.test_check: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestDiscovery.test_discover: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestBasicRead.test_read: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestFullRefresh.test_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
================= 22 passed, 6 skipped, 30 warnings in 17.84s ==================

lmossman · 2023-03-24T21:26:54Z

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4515497876
❌ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4515497876
🐛 https://gradle.com/s/u6jwzystsaike

Build Failed

Test summary info:

Could not find result summary

lmossman · 2023-03-24T23:28:31Z

/test connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4516175306
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/4516175306
No Python unittests run

Build Passed

Test summary info:

All Passed

lmossman · 2023-03-24T23:30:52Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4516185345
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/4516185345
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
=================== 68 passed, 5 skipped in 80.18s (0:01:20) ===================

lmossman · 2023-03-24T23:52:48Z

/publish connector=connectors/source-alloydb

🕑 Publishing the following connectors:
connectors/source-alloydb
https://github.com/airbytehq/airbyte/actions/runs/4516284678

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

lmossman · 2023-03-24T23:53:05Z

/publish connector=connectors/source-alloydb-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-alloydb-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4516285933

Connector	Did it publish?	Were definitions generated?
connectors/source-alloydb-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

lmossman · 2023-03-24T23:53:23Z

/publish connector=connectors/source-mysql

🕑 Publishing the following connectors:
connectors/source-mysql
https://github.com/airbytehq/airbyte/actions/runs/4516286892

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

lmossman · 2023-03-24T23:53:41Z

/publish connector=connectors/source-mysql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mysql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/4516288135

Connector	Did it publish?	Were definitions generated?
connectors/source-mysql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

set ssl_mode to require on remaining db sources

88296f3

octavia-squidington-iii added area/connectors Connector related issues connectors/source/mysql connectors/source/postgres connectors/source/mysql-strict-encrypt connectors/source/alloydb connectors/source/alloydb-strict-encrypt labels Mar 24, 2023

update readmes

433be75

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 24, 2023

lmossman requested a review from rodireich March 24, 2023 21:25

lmossman marked this pull request as ready for review March 24, 2023 21:25

lmossman requested a review from a team as a code owner March 24, 2023 21:25

update expected specs

f06181b

rodireich approved these changes Mar 24, 2023

View reviewed changes

octavia-squidington-iii and others added 2 commits March 25, 2023 00:02

auto-bump connector version

6b3e65c

bump mysql version manually

b2ae91d

lmossman enabled auto-merge (squash) March 25, 2023 01:41

lmossman merged commit 38534b7 into master Mar 25, 2023

lmossman deleted the lmossman/ssl-mode-required-other-db-sources branch March 25, 2023 02:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set ssl_mode to require on remaining strict encrypt db sources #24529

Set ssl_mode to require on remaining strict encrypt db sources #24529

lmossman commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

✅ Sources (5)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

Set ssl_mode to require on remaining strict encrypt db sources #24529

Set ssl_mode to require on remaining strict encrypt db sources #24529

Conversation

lmossman commented Mar 24, 2023 • edited Loading

What

How

github-actions bot commented Mar 24, 2023 • edited Loading

Affected Connector Report

✅ Sources (5)

✅ Destinations (0)

✅ Other Modules (0)

Actionable Items

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Passed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Passed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Passed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Failed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Passed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

Build Passed

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

lmossman commented Mar 24, 2023 • edited by github-actions bot Loading

lmossman commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 24, 2023 •

edited

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading

lmossman commented Mar 24, 2023 •

edited by github-actions bot

Loading