-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Stripe: Add new stream (credit_notes) #24666
Closed
mrhallak
wants to merge
8
commits into
airbytehq:master
from
mrhallak:mrhallak/add-new-stream-credit-notes-to-stripe
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
13fd823
Source Stripe: Add new stream (credit_notes)
mrhallak 7379950
Bug fix
mrhallak e9c2fc3
Update stripe.md
mrhallak d89609c
Merge branch 'master' into mrhallak/add-new-stream-credit-notes-to-st…
mrhallak 1c53b9c
Update stripe.md
mrhallak 01c1f5f
Update source_definitions.yaml
mrhallak c4692ff
Merge remote-tracking branch 'origin' into mrhallak/add-new-stream-cr…
archangelic b08186e
iterate version
archangelic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
airbyte-integrations/connectors/source-stripe/source_stripe/schemas/credit_notes.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| { | ||
| "type": [ | ||
| "null", | ||
| "object" | ||
| ], | ||
| "properties": { | ||
| "metadata": { | ||
| "type": [ | ||
| "null", | ||
| "object" | ||
| ], | ||
| "properties": {} | ||
| }, | ||
| "id": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "total": { | ||
| "type": [ | ||
| "null", | ||
| "number" | ||
| ] | ||
| }, | ||
| "amount": { | ||
| "type": [ | ||
| "null", | ||
| "number" | ||
| ] | ||
| }, | ||
| "voided_at": { | ||
| "type": [ | ||
| "null", | ||
| "integer" | ||
| ] | ||
| }, | ||
| "created": { | ||
| "type": [ | ||
| "null", | ||
| "integer" | ||
| ] | ||
| }, | ||
| "number": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "subtotal": { | ||
| "type": [ | ||
| "null", | ||
| "number" | ||
| ] | ||
| }, | ||
| "livemode": { | ||
| "type": [ | ||
| "null", | ||
| "boolean" | ||
| ] | ||
| }, | ||
| "reason": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "pdf": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "invoice": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "status": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "type": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "currency": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "refund": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "memo": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "customer_balance_transaction": { | ||
| "type": [ | ||
| "null", | ||
| "string" | ||
| ] | ||
| }, | ||
| "discount_amount": { | ||
| "type": [ | ||
| "null", | ||
| "number" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # Airbyte Connectors | ||
|
|
||
| A list of all airbyte connectors can now be found [here](https://connectors.airbyte.com/files/generated_reports/connector_registry_report.html) (or in the [docs](https://docs.airbyte.com/integrations/)). | ||
|
|
||
| This report is generated from the **Airbyte Catalog Registries** | ||
| * [OSS Registry JSON](https://connectors.airbyte.com/files/registries/v0/oss_registry.json) | ||
| * [Cloud Registry JSON](https://connectors.airbyte.com/files/registries/v0/cloud_registry.json) | ||
| # Airbyte Connectors | ||
| A list of all airbyte connectors can now be found [here](https://connectors.airbyte.com/files/generated_reports/connector_registry_report.html) (or in the [docs](https://docs.airbyte.com/integrations/)). | ||
| This report is generated from the **Airbyte Catalog Registries** | ||
| * [OSS Registry JSON](https://connectors.airbyte.com/files/registries/v0/oss_registry.json) | ||
| * [Cloud Registry JSON](https://connectors.airbyte.com/files/registries/v0/cloud_registry.json) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@archangelic This class should similar to this one:
airbyte/airbyte-integrations/connectors/source-stripe/source_stripe/streams.py
Lines 240 to 257 in 5707e47
because
CreditNotesdoesn't support incremental.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference is CreditNotes allow you to set the
limitparameter so you can keep that inrequest_params.