Increase time-out of tests? #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
approved these changes
Mar 18, 2021
ChristopheDuong
commented
Mar 18, 2021
| @@ -766,7 +766,7 @@ private void deleteDestination(UUID destinationId) throws ApiException { | |||
| private static void waitForSuccessfulJob(JobsApi jobsApi, JobRead originalJob) throws InterruptedException, ApiException { | |||
| JobRead job = originalJob; | |||
| int count = 0; | |||
| while (count < 15 && (job.getStatus() == JobStatus.PENDING || job.getStatus() == JobStatus.RUNNING)) { | |||
| while (count < 60 && (job.getStatus() == JobStatus.PENDING || job.getStatus() == JobStatus.RUNNING)) { | |||
There was a problem hiding this comment.
I added 45 secs to the timeout just for trying things out... not sure if we could bump in a smaller increment or is this fine?
cgardens
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I'm wondering If we don't need to increase the time for the sync to run...
in my PR #2460, I've enabled normalization to be running in the acceptance tests so it might need more room