Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove files that are needed to run airbyte-platform #25323

Merged
merged 5 commits into from
Apr 24, 2023
+6 −508
Merged

remove files that are needed to run airbyte-platform #25323

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2398ea6
remove files that are needed to run airbyte-platform
c-p-b Apr 19, 2023
133e76d
make run-ab-platform.sh the canonical version location
c-p-b Apr 20, 2023
17e572a
remove version bump used for testing
c-p-b Apr 20, 2023
d156272
pull files from correct version of platform
c-p-b Apr 21, 2023
004db8e
Merge branch 'master' into remove-ab-platform-files
Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 0 additions & 122 deletions .env
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will actually colide with the PR Joey just did: #25311 since we're reading the VERSION from this file at the moment to figure out which OSS release to load. This also seems to be correctly bumped still in the release process. Should we write that in some other specific file and adjust the run platform script again, or keep just a VERSION around in this file, or some fully other solution?

Copy link
Contributor Author

@c-p-b c-p-b Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should create something like an extensionless VERSION file that has this format, and only has one line in it that has version line identically as it looks in the .env (to save work changing things downstream). Maybe call it PLATFORM_VERSION or something. I would rather leave .env gitignored so that it's super clear that it's identical and coming from the platform.

Any particular feelings about the name or file format for this hypothetical one line file?

Copy link
Contributor Author

@c-p-b c-p-b Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another, kind of cleaner possibly solution is to just store that version in run-ab-platform.sh and have bumpversion.cfg hit that instead. Then it's SUPER clear that it refers to the platform version and keeps everything in one file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel PLATFORM_VERSION would be a nice name and being clear enough, alternatively we could call it CURRENT_PLATFORM_VERSION, but at some point this name is just getting too long :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The canonical version now lives in run-ab-platform.sh after this change (in order to make downloading and running airbyte just wget a single file instead of having to clone entire airbyte repo)

This file was deleted.

38 changes: 0 additions & 38 deletions .env.dev
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions docker-compose.debug.yaml
View file
Open in desktop

This file was deleted.

Loading