New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git to get latest tag #25355

Closed

josephkmh wants to merge 1 commit into master from joey/tag-from-git

Contributor

josephkmh commented Apr 20, 2023

What

I recently merged a change to ./run-ab-platform.sh that targets the correct version when downloading assets: #25311

My approach was to use .env as a source of truth. It turns out that during our GHA to publish a new OSS version, .env gets deleted right before we try to download those assets 🙃 . See related failure here: https://github.com/airbytehq/airbyte-platform-internal/actions/runs/4752327395/jobs/8443714748

This PR changes how we get the latest tag. Instead of looking in .env for a VERSION, it checks the latest tag with git.


          use git to get tag

97a24e8

josephkmh requested review from timroes and c-p-b

April 20, 2023 11:06

josephkmh closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet