Metadata Upload: target production GCS bucket #25529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnchrch
changed the title
alafanechere
approved these changes
Apr 26, 2023
alafanechere
requested changes
Apr 26, 2023
| @@ -28,7 +28,7 @@ jobs: | |||
| GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} | |||
| GCS_CREDENTIALS: ${{ secrets.METADATA_SERVICE_DEV_GCS_CREDENTIALS }} | |||
| METADATA_SERVICE_ACCOUNT_KEY: ${{ secrets.METADATA_SERVICE_DEV_GCS_CREDENTIALS }} | |||
There was a problem hiding this comment.
@bnchrch this SA should be updated too. I think we now have permission to create sercrets.
bnchrch
force-pushed
the
bnchrch/dagster/target-production-bucket
branch
from
18363dd to
830c721
Compare
alafanechere
approved these changes
Apr 26, 2023
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
* Update spec mask to be generated from sensor * Update publish to use production bucket * Update env variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We need metadata files uploading to the production bucket
closes #25091
How
This updates publish to target prod-airbyte-cloud-connector-metadata-service instead of dev-airbyte-cloud-connector-metadata-service
This also updates our spec mask to generate at the same time as the registry
Before merge
After merge