connectors-ci: load secrets on unit tests #25557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alafanechere
commented
Apr 26, 2023
| @@ -11,7 +11,7 @@ data: | |||
| connectorSubtype: api | |||
| connectorType: source | |||
| definitionId: 4bfac00d-ce15-44ff-95b9-9e3c3e8fbd35 | |||
| dockerImageTag: 2.0.6 | |||
| dockerImageTag: 3.0.1 | |||
There was a problem hiding this comment.
I'm bumping the version here to trigger the tests on this source and eventually publish on merge.
bnchrch
approved these changes
Apr 27, 2023
alafanechere
deleted the
augustin/connectors-ci/load-secrets-for-unit-tests
branch
marcosmarxm
pushed a commit
to natalia-miinto/airbyte
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Relates to #25053
I figured that some connector rely on the existence of secrets configs to run unit tests.
I think it's a bad pattern but I'd like our CI pipeline to adapt to this reality instead of fixing these connectors.
(This connector is source-tiktok-marketing)
How
Download secrets before running unit tests.
Mount the secret directory to the container under test in unit tests.