Publish source-facebook-marketing with stream status messages #25559

jdpgrailsdev · 2023-04-26T14:55:13Z

What

Publish new version of the connector that supports stream status messages

How

Bump the CDK version used by the connector
Bump the version of the connector
Update the connector changelog

🚨 User Impact 🚨

None

jdpgrailsdev · 2023-04-26T14:56:01Z

/test connector=connectors/source-facebook-marketing local_cdk=1

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4810182768
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4810182768
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             26      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              42      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/source.py                            61      6    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  125     29    77%
-------------------------------------------------------------------------------
TOTAL                                                        1006     87    91%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/spec.py                              42      1    98%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             26     10    62%
source_facebook_marketing/source.py                            61     24    61%
source_facebook_marketing/streams/streams.py                  125     50    60%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1006    404    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 4116.55s (1:08:36) ==================

jdpgrailsdev · 2023-04-26T18:49:20Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4812288870

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	0.3.5	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jdpgrailsdev · 2023-04-26T21:01:01Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4813323635

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	0.3.5	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jdpgrailsdev · 2023-04-27T13:20:50Z

/publish connector=connectors/source-facebook-marketing

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4820294182

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	0.3.5	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jdpgrailsdev · 2023-04-27T14:04:42Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4820727133

bazarnov · 2023-04-27T14:10:54Z

@jdpgrailsdev We are currently off the rate limits for this connector, please hold for some time, until it's restored. Thank you.

jdpgrailsdev · 2023-04-27T14:13:15Z

/publish connector=connectors/source-facebook-marketing --run-tests=false

@jdpgrailsdev We are currently off the rate limits for this connector, please hold for some time, until it's restored. Thank you.

@bazarnov Are you asking me to wait to publish the connector? If so, do you know what the ETA on when I would be able to do that?

Error: Unexpected inputs provided: ["--run-tests"]

bazarnov · 2023-04-27T14:33:46Z

/publish connector=connectors/source-facebook-marketing --run-tests=false

@jdpgrailsdev We are currently off the rate limits for this connector, please hold for some time, until it's restored. Thank you.

@bazarnov Are you asking me to wait to publish the connector? If so, do you know what the ETA on when I would be able to do that?

Error: Unexpected inputs provided: ["--run-tests"]

Without the tests - you can, otherwise, you're blocked, no ETA when the limits will be restored, probably a couple of hours o so.

jdpgrailsdev · 2023-04-27T14:38:02Z

/publish connector=connectors/source-facebook-marketing --run-tests=false

Error: Unexpected inputs provided: ["--run-tests"]

jdpgrailsdev · 2023-04-27T14:44:07Z

/publish connector=connectors/source-facebook-marketing run-tests=false

🕑 Publishing the following connectors:
connectors/source-facebook-marketing
https://github.com/airbytehq/airbyte/actions/runs/4821141643

Connector	Version	Did it publish?	Were definitions generated?
connectors/source-facebook-marketing	0.3.5	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jdpgrailsdev · 2023-04-27T15:32:20Z

/approve-and-merge reason="PR approved by Alex"

octavia-approvington · 2023-04-27T15:32:58Z

It's time

…ehq#25559) * Prepare to publish source-facebook-marketing * Bump required CDK version * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

jdpgrailsdev added 2 commits April 26, 2023 10:32

Prepare to publish source-facebook-marketing

2a0a509

Bump required CDK version

8524f7e

jdpgrailsdev requested a review from girarda April 26, 2023 14:55

octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Apr 26, 2023

Merge branch 'master' into jonathan/publish-source-facebook-marketing

160bc39

girarda approved these changes Apr 26, 2023

View reviewed changes

Merge branch 'master' into jonathan/publish-source-facebook-marketing

848922f

Merge branch 'master' into jonathan/publish-source-facebook-marketing

4026f9b

auto-bump connector version

287358e

octavia-approvington approved these changes Apr 27, 2023

View reviewed changes

octavia-approvington merged commit 8a01d05 into master Apr 27, 2023

octavia-approvington deleted the jonathan/publish-source-facebook-marketing branch April 27, 2023 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Publish source-facebook-marketing with stream status messages #25559

Publish source-facebook-marketing with stream status messages #25559

jdpgrailsdev commented Apr 26, 2023

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 27, 2023

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 27, 2023

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023

octavia-approvington commented Apr 27, 2023

Publish source-facebook-marketing with stream status messages #25559

Publish source-facebook-marketing with stream status messages #25559

Conversation

jdpgrailsdev commented Apr 26, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

jdpgrailsdev commented Apr 26, 2023 • edited by github-actions bot Loading

Build Passed

jdpgrailsdev commented Apr 26, 2023 • edited by github-actions bot Loading

jdpgrailsdev commented Apr 26, 2023 • edited by github-actions bot Loading

jdpgrailsdev commented Apr 27, 2023 • edited by github-actions bot Loading

jdpgrailsdev commented Apr 27, 2023 • edited by github-actions bot Loading

bazarnov commented Apr 27, 2023

jdpgrailsdev commented Apr 27, 2023 • edited by github-actions bot Loading

bazarnov commented Apr 27, 2023

jdpgrailsdev commented Apr 27, 2023 • edited by github-actions bot Loading

jdpgrailsdev commented Apr 27, 2023 • edited by github-actions bot Loading

jdpgrailsdev commented Apr 27, 2023

octavia-approvington commented Apr 27, 2023

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 26, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading

jdpgrailsdev commented Apr 27, 2023 •

edited by github-actions bot

Loading