Pin MarkupSafe for normalization #25577

jcowanpdx · 2023-04-26T18:37:55Z

What

Trigger Normalization build error on publish

Normalization for Oracle was failing on a python dependency error

How

Internet solution appears to pin the MarkupSafe version: dbt-labs/dbt-core#4745 (comment)

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?

For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

jcowanpdx · 2023-04-26T18:41:10Z

/publish connector=connectors/destination-oracle

🕑 Publishing the following connectors:
connectors/destination-oracle
https://github.com/airbytehq/airbyte/actions/runs/4812228421

Connector	Version	Did it publish?	Were definitions generated?
connectors/destination-oracle	0.1.20	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2023-04-26T18:44:03Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector or module version
Add changelog
Publish the new version

✅ Sources (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

❌ Destinations (15)

Connector	Version	Changelog	Publish
`destination-bigquery`	`1.3.1`	✅	✅
`destination-bigquery-denormalized`	`1.3.1`	✅	✅
`destination-clickhouse`	`0.2.3`	✅	✅
`destination-clickhouse-strict-encrypt`	`0.2.3`	🔵 (ignored)	🔵 (ignored)
`destination-mssql`	`0.1.23`	✅	✅
`destination-mssql-strict-encrypt`	`0.1.23`	🔵 (ignored)	🔵 (ignored)
`destination-mysql`	`0.1.20`	✅	✅
`destination-mysql-strict-encrypt`	❌ `0.1.21` (mismatch: `0.1.20`)	🔵 (ignored)	🔵 (ignored)
`destination-oracle`	`0.1.19`	✅	✅
`destination-oracle-strict-encrypt`	`0.1.19`	🔵 (ignored)	🔵 (ignored)
`destination-postgres`	`0.3.27`	✅	✅
`destination-postgres-strict-encrypt`	`0.3.27`	🔵 (ignored)	🔵 (ignored)
`destination-redshift`	`0.4.5`	✅	✅
`destination-snowflake`	`0.4.61`	✅	✅
`destination-tidb`	`0.1.1`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

👀 Other Modules (1)

base-normalization

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

per (dbt-labs/dbt-core#4745 (comment))

jcowanpdx · 2023-04-26T18:53:37Z

/publish connector=connectors/destination-oracle

🕑 Publishing the following connectors:
connectors/destination-oracle
https://github.com/airbytehq/airbyte/actions/runs/4812320649

Connector	Version	Did it publish?	Were definitions generated?
connectors/destination-oracle	0.1.20	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jcowanpdx · 2023-04-26T20:01:58Z

/publish connector=connectors/destination-oracle

🕑 Publishing the following connectors:
connectors/destination-oracle
https://github.com/airbytehq/airbyte/actions/runs/4812857495

Connector	Version	Did it publish?	Were definitions generated?
connectors/destination-oracle	0.1.20	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jcowanpdx · 2023-04-26T21:21:07Z

/publish connector=connectors/destination-bigquery

🕑 Publishing the following connectors:
connectors/destination-bigquery
https://github.com/airbytehq/airbyte/actions/runs/4813499996

Connector	Version	Did it publish?	Were definitions generated?
connectors/destination-bigquery	1.3.2	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

jcowanpdx · 2023-04-26T22:02:48Z

Okay, I got a publish to run successfully. Going to revert the actual version changes and we can just commit the normalization piece.

This reverts commit 1fc17e3.

This reverts commit 52ed3f0.

… error." This reverts commit ecbad7f.

ryankfu · 2023-04-26T22:23:23Z

/test connector=bases/base-normalization

🕑 bases/base-normalization https://github.com/airbytehq/airbyte/actions/runs/4813920882

airbyte-integrations/bases/base-normalization/oracle.Dockerfile

edgao

let's just merge this in (without the normalization bump?) since it seems like it makes the build green.

I doubt anyone is publishing normalization right now anyway 🤷

We were running into a CI/CD system-only bug with dbt that requires this workaround to get it working --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

bump version to testing the publish command and normalization error.

ecbad7f

jcowanpdx requested a review from a team as a code owner April 26, 2023 18:37

octavia-squidington-iii added area/connectors Connector related issues connectors/destination/oracle labels Apr 26, 2023

try pinning the MarkupSafe version to get around a transient build error

6666e8a

per (dbt-labs/dbt-core#4745 (comment))

octavia-squidington-iii added the normalization label Apr 26, 2023

let's try building BigQuery

52ed3f0

octavia-squidington-iii added the connectors/destination/bigquery label Apr 26, 2023

auto-bump connector version

1fc17e3

jcowanpdx added 3 commits April 26, 2023 15:05

Revert "auto-bump connector version"

a8b644e

This reverts commit 1fc17e3.

Revert "let's try building BigQuery"

e5fb64d

This reverts commit 52ed3f0.

Revert "bump version to testing the publish command and normalization…

988db0d

… error." This reverts commit ecbad7f.

octavia-squidington-iii removed the area/connectors Connector related issues label Apr 26, 2023

bnchrch reviewed Apr 26, 2023

View reviewed changes

airbyte-integrations/bases/base-normalization/oracle.Dockerfile Outdated Show resolved Hide resolved

bnchrch approved these changes Apr 26, 2023

View reviewed changes

increment the image version and add a link to the dbt issue in question

dae56e7

jcowanpdx changed the title ~~bump version to testing the publish command and normalization error.~~ Pin MarkupSafe for normalization Apr 26, 2023

edgao approved these changes Apr 26, 2023

View reviewed changes

jcowanpdx enabled auto-merge (squash) April 26, 2023 23:16

jcowanpdx merged commit 3a308ba into master Apr 26, 2023

jcowanpdx deleted the jeff/fix_norm_build_error branch April 26, 2023 23:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin MarkupSafe for normalization #25577

Pin MarkupSafe for normalization #25577

jcowanpdx commented Apr 26, 2023 •

edited by ryankfu

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Apr 26, 2023 •

edited

Loading

✅ Sources (0)

❌ Destinations (15)

👀 Other Modules (1)

Actionable Items

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

jcowanpdx commented Apr 26, 2023

ryankfu commented Apr 26, 2023 •

edited by github-actions bot

Loading

edgao left a comment

Pin MarkupSafe for normalization #25577

Pin MarkupSafe for normalization #25577

Conversation

jcowanpdx commented Apr 26, 2023 • edited by ryankfu Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

jcowanpdx commented Apr 26, 2023 • edited by github-actions bot Loading

github-actions bot commented Apr 26, 2023 • edited Loading

Affected Connector Report

✅ Sources (0)

❌ Destinations (15)

👀 Other Modules (1)

Actionable Items

jcowanpdx commented Apr 26, 2023 • edited by github-actions bot Loading

jcowanpdx commented Apr 26, 2023 • edited by github-actions bot Loading

jcowanpdx commented Apr 26, 2023 • edited by github-actions bot Loading

jcowanpdx commented Apr 26, 2023

ryankfu commented Apr 26, 2023 • edited by github-actions bot Loading

edgao left a comment

Choose a reason for hiding this comment

jcowanpdx commented Apr 26, 2023 •

edited by ryankfu

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Apr 26, 2023 •

edited

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

jcowanpdx commented Apr 26, 2023 •

edited by github-actions bot

Loading

ryankfu commented Apr 26, 2023 •

edited by github-actions bot

Loading