-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Genesys: Use region specific API server #25598
🐛 Source Genesys: Use region specific API server #25598
Conversation
Unit tests
|
airbyte-integrations/connectors/source-genesys/source_genesys/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-genesys/source_genesys/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-genesys/source_genesys/source.py
Outdated
Show resolved
Hide resolved
@marcosmarxm - I've refactored the code. Please review. |
@sajarin @marcosmarxm - Gentle reminder to review this PR. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
3563216
to
1d87228
Compare
@sajarin @marcosmarxm - Gentle reminder to review this PR. Thanks! |
Hello @Shishir-rmv right now Genesys CI is broken and the PR is in our backlog. Hope to get any update in next weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Shishir-rmv right now the tests aren't working but the implementation looks correct.
/approve-and-merge reason="no credentials to run tests" |
* use api url corresponding to region specified in the config * update unit tests * bump up version * refactor
What
This solves: #22360
How
Use region specified in the configuration to select the relevant API URL. Maps region to API server as documented here
Recommended reading order
airbyte-integrations/connectors/source-genesys/source_genesys/source.py
airbyte-integrations/connectors/source-genesys/unit_tests/test_source.py
airbyte-integrations/connectors/source-genesys/unit_tests/test_streams.py
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user?
No breaking changes
For connector PRs, use this section to explain which type of semantic versioning bump occurs as a result of the changes. Refer to our Semantic Versioning for Connectors guidelines for more information. Breaking changes to connectors must be documented by an Airbyte engineer (PR author, or reviewer for community PRs) by using the Breaking Change Release Playbook.
If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with
airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.Code reviews completed
Connector version has been incremented
Dockerfile
has updated versionDocumentation updated
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
with an entry for the new version. See changelog examplePR name follows PR naming conventions
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described here