Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Hubspot: fix CAT tests #25601

Merged
merged 7 commits into from
Apr 28, 2023
Merged

Conversation

bazarnov
Copy link
Collaborator

What

Based on this CAT test: https://github.com/airbytehq/airbyte/actions/runs/4815554992
need to ignore certain fields for companies stream to pass the CAT

How

  • ignore properties/hs_all_* while basic_read to satisfy expected records check

@bazarnov
Copy link
Collaborator Author

bazarnov commented Apr 27, 2023

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4820747948
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4820747948
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       894     77    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                          1034     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       894    215    76%
-------------------------------------------------
TOTAL                          1034    236    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 441.58s (0:07:21) ===================

@bazarnov
Copy link
Collaborator Author

bazarnov commented Apr 27, 2023

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4821265679
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/4821265679
Python tests coverage:

Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      3    96%
source_hubspot/streams.py       894     77    91%
source_hubspot/source.py         60     19    68%
-------------------------------------------------
TOTAL                          1034     99    90%
Name                          Stmts   Miss  Cover
-------------------------------------------------
source_hubspot/errors.py          6      0   100%
source_hubspot/constants.py       2      0   100%
source_hubspot/__init__.py        2      0   100%
source_hubspot/helpers.py        70      7    90%
source_hubspot/source.py         60     14    77%
source_hubspot/streams.py       894    215    76%
-------------------------------------------------
TOTAL                          1034    236    77%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 40 passed, 2 skipped in 447.92s (0:07:27) ===================

@bazarnov bazarnov requested a review from erohmensing April 27, 2023 14:59
@bazarnov bazarnov merged commit 526eb3b into master Apr 28, 2023
@bazarnov bazarnov deleted the baz/source-hubspot-fix-cat branch April 28, 2023 09:37
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants