🐛 Source Facebook Marketing: fix `expected records` for CAT #25604

bazarnov · 2023-04-27T12:02:50Z

What

Based on this CAT test: https://github.com/airbytehq/airbyte/actions/runs/4815545689
need to update the expected records for ads_insights stream

How

updated expected_records.jsonl

bazarnov · 2023-04-27T12:03:34Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4819511281
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4819511281
🐛 https://gradle.com/s/fsj3tx7vqxfm6

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: Stream ads_i...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
============= 1 failed, 37 passed, 2 skipped in 1744.50s (0:29:04) =============

bazarnov · 2023-04-27T12:48:42Z

Failed with Rate Limits.

…ting-fix-exp-rec

bazarnov · 2023-04-28T18:23:14Z

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4833624168
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/4833624168
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             26      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              42      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/api.py                               96      9    91%
source_facebook_marketing/source.py                            61      6    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  125     29    77%
-------------------------------------------------------------------------------
TOTAL                                                        1006     87    91%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/spec.py                              42      1    98%
source_facebook_marketing/api.py                               96     12    88%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             26     10    62%
source_facebook_marketing/source.py                            61     24    61%
source_facebook_marketing/streams/streams.py                  125     50    60%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1006    404    60%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:578: The previous and actual discovered catalogs are identical.
================== 38 passed, 2 skipped in 1911.97s (0:31:51) ==================

* map the other integer schema to long * fix test + add test * delete_public_access_block for bucket if public (#25663) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> * 🐛 Source Facebook Marketing: fix `expected records` for CAT (#25604) * publish normalization (#25591) * publish normalization * bump normalization container version in all the destinations that use it Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: edgao <edgao@users.noreply.github.com> * Bump Airbyte version from 0.44.2 to 0.44.3 * Destination Bigquery: update AIRBYTE_ENTRYPOINT env var for kube process (#25588) * add AIRBYTE_ENTRYPOINT env var for kube * amazing, absolute genius * version bump + changelog * derp, no need to publish denormalizeid * fix changelog entry * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * version bumps + changelog * whoops * bump metadata * bump metadatas * auto-bump connector version * auto-bump connector version * auto-bump connector version * auto-bump connector version * auto-bump connector version --------- Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com> Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com> Co-authored-by: Jeff Cowan (Airbyte) <4992320+jcowanpdx@users.noreply.github.com> Co-authored-by: edgao <edgao@users.noreply.github.com> Co-authored-by: benmoriceau <benmoriceau@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

…q#25604)

…#25570) * map the other integer schema to long * fix test + add test * delete_public_access_block for bucket if public (airbytehq#25663) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> * 🐛 Source Facebook Marketing: fix `expected records` for CAT (airbytehq#25604) * publish normalization (airbytehq#25591) * publish normalization * bump normalization container version in all the destinations that use it Co-authored-by: Edward Gao <edward.gao@airbyte.io> Co-authored-by: edgao <edgao@users.noreply.github.com> * Bump Airbyte version from 0.44.2 to 0.44.3 * Destination Bigquery: update AIRBYTE_ENTRYPOINT env var for kube process (airbytehq#25588) * add AIRBYTE_ENTRYPOINT env var for kube * amazing, absolute genius * version bump + changelog * derp, no need to publish denormalizeid * fix changelog entry * auto-bump connector version --------- Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com> * version bumps + changelog * whoops * bump metadata * bump metadatas * auto-bump connector version * auto-bump connector version * auto-bump connector version * auto-bump connector version * auto-bump connector version --------- Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com> Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com> Co-authored-by: Baz <oleksandr.bazarnov@globallogic.com> Co-authored-by: Jeff Cowan (Airbyte) <4992320+jcowanpdx@users.noreply.github.com> Co-authored-by: edgao <edgao@users.noreply.github.com> Co-authored-by: benmoriceau <benmoriceau@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

updated

99d8679

bazarnov self-assigned this Apr 27, 2023

octavia-squidington-iii added area/connectors Connector related issues connectors/source/facebook-marketing labels Apr 27, 2023

bazarnov requested a review from artem1205 April 27, 2023 12:03

artem1205 approved these changes Apr 27, 2023

View reviewed changes

bazarnov added 4 commits April 28, 2023 12:47

Merge branch 'master' into baz/source-fb-marketing-fix-exp-rec

b1bd9a3

Merge remote-tracking branch 'origin/master' into baz/source-fb-marke…

13c78a2

…ting-fix-exp-rec

updated

f17f6c2

Merge branch 'master' into baz/source-fb-marketing-fix-exp-rec

9975815

bazarnov merged commit a8883ad into master Apr 28, 2023

bazarnov deleted the baz/source-fb-marketing-fix-exp-rec branch April 28, 2023 19:30

edgao pushed a commit that referenced this pull request Apr 28, 2023

🐛 Source Facebook Marketing: fix expected records for CAT (#25604)

5f97ebb

marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023

🐛 Source Facebook Marketing: fix expected records for CAT (airbyteh…

0920997

…q#25604)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Facebook Marketing: fix `expected records` for CAT #25604

🐛 Source Facebook Marketing: fix `expected records` for CAT #25604

bazarnov commented Apr 27, 2023

bazarnov commented Apr 27, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 27, 2023

bazarnov commented Apr 28, 2023 •

edited by github-actions bot

Loading

🐛 Source Facebook Marketing: fix expected records for CAT #25604

🐛 Source Facebook Marketing: fix expected records for CAT #25604

Conversation

bazarnov commented Apr 27, 2023

What

How

bazarnov commented Apr 27, 2023 • edited by github-actions bot Loading

Build Failed

bazarnov commented Apr 27, 2023

bazarnov commented Apr 28, 2023 • edited by github-actions bot Loading

Build Passed

🐛 Source Facebook Marketing: fix `expected records` for CAT #25604

🐛 Source Facebook Marketing: fix `expected records` for CAT #25604

bazarnov commented Apr 27, 2023 •

edited by github-actions bot

Loading

bazarnov commented Apr 28, 2023 •

edited by github-actions bot

Loading