Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector builder doc fixes #25645

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Connector builder doc fixes #25645

merged 1 commit into from
Apr 27, 2023

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Apr 27, 2023 •
edited
Loading

A couple small fixes to the newly introduced connector builder documentation:

  • Improve wording
  • Fix typo
  • Fix broken link and wrong slack channel name
  • Add missing section to the sidebar

@flash1293 flash1293 added the area/documentation Improvements or additions to documentation label Apr 27, 2023
@flash1293 flash1293 requested a review from timroes April 27, 2023 19:24
timroes
timroes approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@flash1293 flash1293 merged commit 1ab5f91 into master Apr 27, 2023
@flash1293 flash1293 deleted the flash1293/doc-fixes branch April 27, 2023 19:38
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
@marcosmarxm
doc fixes (airbytehq#25645)
305d0a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flash1293 @timroes