Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bg color of row to white for dark mode #25675

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

evantahler
Copy link
Contributor

Fix this:
Screenshot 2023-04-28 at 10 09 56 AM

@evantahler evantahler requested a review from bnchrch April 28, 2023 17:10
@evantahler evantahler marked this pull request as ready for review April 28, 2023 17:10
@evantahler
Copy link
Contributor Author

@bnchrch what do I need to do to rebuild the file... will it update on merge?

Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @evantahler this will get run on the next change to the registry file after deploy.

Or after this deploys you can go here
https://airbyte-connectors.dagster.cloud/prod/locations/metadata_service_orchestrator/jobs/generate_registry_reports

and click "materialize all"

Now there is one catch!

There is an issue with Dagger (only when called from GHA) running the deploy orchestrator command right now which we have in the backlog.

So to deploy we have to call airbyte-ci locally.

Ill slack you the secret, and you can let me know if you want me to do it for you :0

DAGSTER_CLOUD_METADATA_API_TOKEN="REDACTED" airbyte-ci metadata deploy orchestrator

@evantahler evantahler merged commit 28901c1 into master Apr 28, 2023
@evantahler evantahler deleted the evan/connector-registry-dark-mode branch April 28, 2023 17:28
marcosmarxm pushed a commit to natalia-miinto/airbyte that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants