Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output actual AirbyteMessages for cdc #2631

Merged
merged 2 commits into from
Mar 30, 2021

Conversation

jrhizor
Copy link
Contributor

@jrhizor jrhizor commented Mar 27, 2021

The main things I wanted address:

  1. setting _ab_cdc_deleted_at to null instead of omitting it
  2. the fact that inserts and updates look identical since they just set updated_at

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes because the method for getting CDC iterators is hard to follow. Also, why is setting deleted_at to null better than just omitting it? it should end up being the same thing in the destination, right?

final Iterator<JsonNode> queueIterator = Queues.toStream(queue).iterator();
final AbstractIterator<JsonNode> iterator = new AbstractIterator<>() {
final Iterator<AirbyteMessage> queueIterator = Queues.toStream(queue).iterator();
final AbstractIterator<AirbyteMessage> iterator = new AbstractIterator<>() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this in-line class definition really threw me off while reading this code. Why don't we refactor it out of this method? The method is pretty large right now which makes it hard to follow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still a lot we're trying to lock down here right now. i agree, we will want to refactor this to make the responsibility of each piece more clear and testable. can we get a pass on this for now while we are still making pretty big code changes in this area?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@jrhizor jrhizor merged commit 9be6bcf into jrhizor/debezium Mar 30, 2021
@jrhizor jrhizor deleted the jrhizor/message-conversion branch March 30, 2021 17:46
jrhizor added a commit that referenced this pull request Apr 9, 2021
* spike

* more

* debezium wip

* use oneof for configuration

* iterator wrapping structure

* push current

* working loop

* move capability into source

* hack it into a sharable state

* debezium test runner (#2617)

* CDC Wait for Values (#2618)

* output actual AirbyteMessages for cdc (#2631)

* message conversion

* fmt

* add lsn extraction and comparison (#2613)

* postgres cdc catalog (#2673)

* update cdc catalog

* A

* table selection for cdc (#2690)

* table selection for cdc

* fix broken merge

* also test double quote in name

* Add state management to CDC (#2718)

* CDC: Fix Producer/Consumer State Machine (#2721)

* CDC Postgres Tests (#2777)

* fix postgres cdc image name and run check before reading data (#2785)

* minor postgres cdc fixes

* add test and fix check behavior

* fix

* improve comment

* remove unused props, remove todos, add some more sanity tests (#2791)

* cdc: add offset store tests (#2793)

* clean (#2798)

* postgres cdc docs (#2784)

* cdc docs

* Update docs/integrations/sources/postgres.md

Co-authored-by: Charles <giardina.charles@gmail.com>

* address gcp

* learn too english

* add link

* add more disk space warnings

* add additional cdc use case

* add information on how to find postgresql.conf

* add how to find the file

Co-authored-by: Charles <giardina.charles@gmail.com>

* various merge conflict fixes (#2799)

* cdc standard tests (#2813)

* require cdc users to create publications & update docs (#2818)

* postgres cdc race condition

* working? but different process

* add additional logging to help debug in the future

* everything done except working config

* remove unintended change

* Use oneOf in PG CDC spec (#2827)

* add oneOf configuration for postgres cdc  (#2831)

* add oneof configuration for cdc postgres

* fmt

Co-authored-by: Charles <giardina.charles@gmail.com>

* fix test (#2834)

* fix test

* bump version

* add docs on creating replica identities (#2838)

* add docs on creating replica identities

* emphasize danger

* grammar

* bump pg version in source catalog

* generate seed files

Co-authored-by: cgardens <giardina.charles@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants