Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Jira: add expand on lead field #26920

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Source Jira: add expand on lead field #26920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d56aa13
expand on lead field
jkleinkauff Jun 1, 2023
2c32a6b
bumping connector version
jkleinkauff Jun 1, 2023
69fe9dc
bump connector version on metadata file
jkleinkauff Jun 1, 2023
18fdb9f
update docs
jkleinkauff Jun 1, 2023
33ae3cd
Merge remote-tracking branch 'origin/master' into source-jira-expand-…
jkleinkauff Jun 1, 2023
75f496a
update docs
jkleinkauff Jun 1, 2023
94244dc
bump version
jkleinkauff Jun 1, 2023
bfa6221
update tests added in last source-jira pr
jkleinkauff Jun 1, 2023
ef1c556
Merge branch 'master' into source-jira-expand-lead
jkleinkauff Jun 7, 2023
31d2bf4
fix expcted records
marcosmarxm Jun 7, 2023
f44707c
fix doc
marcosmarxm Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.3.11
LABEL io.airbyte.version=0.3.12
LABEL io.airbyte.name=airbyte/source-jira
33 changes: 15 additions & 18 deletions airbyte-integrations/connectors/source-jira/integration_tests/expected_records.jsonl
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 68e63de2-bb83-4c7e-93fa-a8a9051e3993
dockerImageTag: 0.3.11
dockerImageTag: 0.3.12
maxSecondsBetweenMessages: 21600
dockerRepository: airbyte/source-jira
githubIssueLabel: source-jira
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/source_jira/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ def path(self, **kwargs) -> str:

def request_params(self, **kwargs):
params = super().request_params(**kwargs)
params["expand"] = "description"
params["expand"] = "description,lead"
return params

def read_records(self, **kwargs) -> Iterable[Mapping[str, Any]]:
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/unit_tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def mock_projects_responses(config, projects_response):
Projects.use_cache = False
responses.add(
responses.GET,
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description",
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description%2Clead",
json=projects_response,
)

Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-jira/unit_tests/test_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def test_streams(config):
def test_check_connection(config, projects_response, labels_response):
responses.add(
responses.GET,
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description",
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description%2Clead",
json=projects_response,
)
responses.add(
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-jira/unit_tests/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ def test_filter_sharing_stream(config, filter_sharing_response):
def test_projects_stream(config, projects_response):
responses.add(
responses.GET,
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description",
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description%2Clead",
json=projects_response,
)

Expand Down Expand Up @@ -651,7 +651,7 @@ def test_issues_stream(config, projects_response, mock_issues_responses, issues_
projects_response['values'].append({"id": "3", "key": "Project1"})
responses.add(
responses.GET,
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description",
f"https://{config['domain']}/rest/api/3/project/search?maxResults=50&expand=description%2Clead",
json=projects_response,
)
responses.add(
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/jira.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ The Jira connector should not run into Jira API limitations under normal usage.

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:------------------------------------------------------------------------------------------------------------------------|
| 0.3.12 | 2023-06-01 | [\#26652](https://github.com/airbytehq/airbyte/pull/26652) | Expand on `leads` for `projects` stream |
| 0.3.11 | 2023-06-01 | [\#26906](https://github.com/airbytehq/airbyte/pull/26906) | Handle project permissions error |
| 0.3.10 | 2023-05-26 | [\#26652](https://github.com/airbytehq/airbyte/pull/26652) | Fixed bug when `board` doesn't support `sprints` |
| 0.3.9 | 2023-05-16 | [\#26114](https://github.com/airbytehq/airbyte/pull/26114) | Update fields info in docs and spec, update to latest airbyte-cdk |
Expand Down