-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connector CI: Use one service account #26931
Conversation
Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
46e4598
to
b8f7b55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To move forward on this PR we'd need the global SA to be created first right?
@@ -64,10 +64,7 @@ jobs: | |||
env: | |||
_EXPERIMENTAL_DAGGER_CLOUD_TOKEN: "p.eyJ1IjogIjFiZjEwMmRjLWYyZmQtNDVhNi1iNzM1LTgxNzI1NGFkZDU2ZiIsICJpZCI6ICJlNjk3YzZiYy0yMDhiLTRlMTktODBjZC0yNjIyNGI3ZDBjMDEifQ.hT6eMOYt3KZgNoVGNYI3_v4CC-s19z8uQsBkGrBhU3k" | |||
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the env var / SA should be named like GCP_CI_CREDENTIALS
and would have permissions to:
- Read GSM secrets
- Write to spec cache bucket
- Write to metadata bucket
- Write reports
I also believe these permissions should be mapped to role, and we can create different SA/users with this role. We can have 1 SA for the CI pipeline. We could decide to give a pool of gcloud users (dev conectors ops or full connector org team) the permission to use this role so they can run easily pipelines locally with the same kind of operations that happen in the CI.
What
A demo of what using one service account would look like
TODO before merge
closes: airbytehq/airbyte-internal-issues#1850