Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector CI: Use one service account #26931

Closed
wants to merge 10 commits into from

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Jun 2, 2023

What

A demo of what using one service account would look like

TODO before merge

  1. Give the github ci SA admin access to spec cache
  2. Give thegithub ci SA admin access to the metadata service

closes: airbytehq/airbyte-internal-issues#1850

@bnchrch bnchrch requested a review from alafanechere June 2, 2023 00:25
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Octavia Squidington III seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bnchrch bnchrch force-pushed the bnchrch/dagger/update-nightlies branch from 46e4598 to b8f7b55 Compare June 2, 2023 21:33
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To move forward on this PR we'd need the global SA to be created first right?

@@ -64,10 +64,7 @@ jobs:
env:
_EXPERIMENTAL_DAGGER_CLOUD_TOKEN: "p.eyJ1IjogIjFiZjEwMmRjLWYyZmQtNDVhNi1iNzM1LTgxNzI1NGFkZDU2ZiIsICJpZCI6ICJlNjk3YzZiYy0yMDhiLTRlMTktODBjZC0yNjIyNGI3ZDBjMDEifQ.hT6eMOYt3KZgNoVGNYI3_v4CC-s19z8uQsBkGrBhU3k"
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the env var / SA should be named like GCP_CI_CREDENTIALS and would have permissions to:

  • Read GSM secrets
  • Write to spec cache bucket
  • Write to metadata bucket
  • Write reports

I also believe these permissions should be mapped to role, and we can create different SA/users with this role. We can have 1 SA for the CI pipeline. We could decide to give a pool of gcloud users (dev conectors ops or full connector org team) the permission to use this role so they can run easily pipelines locally with the same kind of operations that happen in the CI.

Base automatically changed from bnchrch/dagger/update-nightlies to master June 6, 2023 16:37
@bnchrch bnchrch closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants