Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Facebook Marketing: migrate to advancedAuth #26941

Merged

Conversation

arsenlosenko
Copy link
Contributor

What

Resolving this issue - #26227

How

Removed authSpecification from spec.json, changed it to advacned_auth instead

@arsenlosenko arsenlosenko self-assigned this Jun 2, 2023
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing labels Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Jun 2, 2023

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5153463836
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5153463836
🐛 https://gradle.com/s/jkzo5hckf4kho

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestSpec::test_match_expected[inputs0] - AssertionError:...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:100: The previous and actual specifications are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
============= 1 failed, 37 passed, 3 skipped in 4221.46s (1:10:21) =============

@arsenlosenko arsenlosenko linked an issue Jun 2, 2023 that may be closed by this pull request
@arsenlosenko arsenlosenko changed the title Source Facebook Marketing: migrate to advancedAuth ✨ Source Facebook Marketing: migrate to advancedAuth Jun 2, 2023
@arsenlosenko arsenlosenko requested review from bazarnov and lazebnyi June 2, 2023 09:29
@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Jun 2, 2023

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5155268112

@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Jun 2, 2023

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5155585671
❌ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5155585671
🐛 https://gradle.com/s/kaz7t7uh4z3fc

Build Failed

Test summary info:

Could not find result summary

@arsenlosenko
Copy link
Contributor Author

arsenlosenko commented Jun 2, 2023

/test connector=connectors/source-facebook-marketing

🕑 connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5156728300
✅ connectors/source-facebook-marketing https://github.com/airbytehq/airbyte/actions/runs/5156728300
Python tests coverage:

Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/utils.py                             26      0   100%
source_facebook_marketing/streams/common.py                    44      0   100%
source_facebook_marketing/streams/async_job.py                217      0   100%
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/streams/async_job_manager.py         78      3    96%
source_facebook_marketing/streams/patches.py                   22      2    91%
source_facebook_marketing/source.py                            62      6    90%
source_facebook_marketing/api.py                               99     10    90%
source_facebook_marketing/streams/base_insight_streams.py     145     16    89%
source_facebook_marketing/streams/base_streams.py             143     22    85%
source_facebook_marketing/streams/streams.py                  160     29    82%
-------------------------------------------------------------------------------
TOTAL                                                        1042     88    92%
Name                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------
source_facebook_marketing/streams/__init__.py                   2      0   100%
source_facebook_marketing/spec.py                              39      0   100%
source_facebook_marketing/__init__.py                           5      0   100%
source_facebook_marketing/api.py                               99     13    87%
source_facebook_marketing/streams/patches.py                   22      3    86%
source_facebook_marketing/streams/base_streams.py             143     28    80%
source_facebook_marketing/streams/streams.py                  160     50    69%
source_facebook_marketing/streams/common.py                    44     16    64%
source_facebook_marketing/utils.py                             26     10    62%
source_facebook_marketing/source.py                            62     24    61%
source_facebook_marketing/streams/base_insight_streams.py     145     64    56%
source_facebook_marketing/streams/async_job.py                217    136    37%
source_facebook_marketing/streams/async_job_manager.py         78     60    23%
-------------------------------------------------------------------------------
TOTAL                                                        1042    404    61%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:598: The previous and actual discovered catalogs are identical.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:695: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 39 passed, 2 skipped in 4568.55s (1:16:08) ==================

@lazebnyi lazebnyi requested review from pedroslopez and removed request for bazarnov June 6, 2023 12:37
@arsenlosenko arsenlosenko merged commit fa3e0a6 into master Jun 8, 2023
@arsenlosenko arsenlosenko deleted the arsenlosenko/26227-source-facebook-marketing-advancedauth branch June 8, 2023 11:49
girarda added a commit that referenced this pull request Jun 8, 2023
[This PR](#26941) seems to be preventing users from saving changes or retesting their existing Source
girarda added a commit that referenced this pull request Jun 8, 2023
* Pin FB marketing to 0.4.0 on Cloud

[This PR](#26941) seems to be preventing users from saving changes or retesting their existing Source

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Facebook Marketing: Migrate to advancedAuth
5 participants