Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDK for source-xero #27007

Merged
merged 12 commits into from
Jun 7, 2023
Merged

Update CDK for source-xero #27007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3cb0ccb
wip
Jun 2, 2023
a754d09
Automated Commit - Formatting Changes
flash1293 Jun 2, 2023
f02205c
add documentation
Jun 5, 2023
944717b
Merge branch 'flash1293/unified-single-use' of github.com:airbytehq/a…
Jun 5, 2023
cc3c4d8
tests and fixes
Jun 5, 2023
d54d2a7
fix tests
Jun 5, 2023
8b8d5df
more documentation
Jun 5, 2023
9cfcd3f
revert
Jun 5, 2023
e3e10b9
update xero
Jun 5, 2023
5a21275
update documentation
Jun 5, 2023
b30568b
update version
Jun 5, 2023
89bb971
Merge remote-tracking branch 'origin/master' into flash1293/update-xero2
Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-xero/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_xero ./source_xero
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.2.1
LABEL io.airbyte.version=0.2.2
LABEL io.airbyte.name=airbyte/source-xero
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-xero/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 6fd1e833-dd6e-45ec-a727-ab917c5be892
dockerImageTag: 0.2.1
dockerImageTag: 0.2.2
dockerRepository: airbyte/source-xero
githubIssueLabel: source-xero
icon: xero.svg
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-xero/source_xero/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ def get_authenticator(config: Mapping[str, Any]) -> Mapping[str, Any]:
return XeroSingleUseRefreshTokenOauth2Authenticator(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd that we have a custom component for that. It seems to be related to HTTP requests we are performing. Eventually, it might be interesting to increase the capabilities of OAuth in the CDK to avoid having those custom things

connector_config=config,
token_refresh_endpoint="https://identity.xero.com/connect/token",
client_id_config_path=["authentication", "client_id"],
client_secret_config_path=["authentication", "client_secret"],
client_id=config["authentication"]["client_id"],
client_secret=config["authentication"]["client_secret"],
access_token_config_path=["authentication", "access_token"],
refresh_token_config_path=["authentication", "refresh_token"],
token_expiry_date_config_path=["authentication", "token_expiry_date"],
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/xero.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ The connector is restricted by Xero [API rate limits](https://developer.xero.com

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :------------------------------------------------------- | :-------------------------------- |
| 0.2.2 | 2023-06-06 | [27007](https://github.com/airbytehq/airbyte/pull/27007) | Update CDK |
| 0.2.1 | 2023-03-20 | [24217](https://github.com/airbytehq/airbyte/pull/24217) | Certify to Beta |
| 0.2.0 | 2023-03-14 | [24005](https://github.com/airbytehq/airbyte/pull/24005) | Enable in Cloud |
| 0.1.0 | 2021-11-11 | [18666](https://github.com/airbytehq/airbyte/pull/18666) | 🎉 New Source - Xero [python cdk] |