Create additional setup guides for top API sources #27101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
the
area/documentation
sherifnada
approved these changes
Jun 8, 2023
docs/integrations/sources/shopify.md
Outdated
|
|
||
| This Source is capable of syncing the following core Streams: | ||
|
|
||
| * [Articles](https://shopify.dev/api/admin-rest/2022-01/resources/article) |
There was a problem hiding this comment.
how come you removed articles and blogs?
There was a problem hiding this comment.
Thanks for catching this. They were in one list but not the other, and I must have taken the older list. Added back.
|
|
||
| Check out common troubleshooting issues for the Shopify source connector on our Discourse [here](https://discuss.airbyte.io/tags/c/connector/11/source-shopify). | ||
|
|
||
| ### Output schema |
There was a problem hiding this comment.
why was this removed from here? Seems useful to have
There was a problem hiding this comment.
It still exists! It was just duplicated twice so I removed the first instance of it. It is now located above the Supported Streams but under the Setup Guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Creates additional setup guides for:
Separating out the setup guides is a cleaner approach for the doc in comparison to OSS / Cloud tags, as it allows for the addition of the text at the bottom that links out to the original doc.
Also does as hot-fix for Shopify, where the Streams information was duplicated inadvertendly