Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Zendesk Support: New Stream - Topics #27208

Merged
merged 17 commits into from
Aug 10, 2023
Merged

✨Source Zendesk Support: New Stream - Topics #27208

merged 17 commits into from
Aug 10, 2023

Conversation

btkcodedev
Copy link
Collaborator

What

Closes #16889

Enhancement

New streams:

  • Topics

Recommended reading order

  1. source_zendesk_support/source.py
  2. source_zendesk_support/streams.py
  3. source_zendesk_support/schemas/*

🚨 User Impact 🚨

No breaking changes

Pre-merge Checklist

Updating a connector

Community member or Airbyter [Yes]

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • Documentation which references the generator is updated as needed

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Jun 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023 •
edited by darynaishchenko
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • You, or an Airbyter, have run /test successfully on this PR - or on a non-forked branch
  • You've updated the connector's metadata.yaml file (new!)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@jrolom jrolom added the contributor-program PRs submitted through the contributor program. label Jun 9, 2023
@darynaishchenko darynaishchenko self-assigned this Jul 6, 2023
darynaishchenko
darynaishchenko requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@darynaishchenko darynaishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add expected_records for this stream?

@btkcodedev
Copy link
Collaborator Author

@darynaishchenko Added expected_records

@darynaishchenko darynaishchenko mentioned this pull request Jul 11, 2023
Closed
@darynaishchenko
Copy link
Collaborator

@btkcodedev could you please fix AT, incremental sync test failed

@btkcodedev
Copy link
Collaborator Author

btkcodedev commented Jul 20, 2023 •
edited
Loading

@darynaishchenko Sorry I don't have access to google cloud, But my local is showing up with incremental sync as passed,
Could you suggest some changes

@darynaishchenko
Copy link
Collaborator

@darynaishchenko Sorry I don't have access to google cloud, But my local is showing up with incremental sync as passed, Could you suggest some changes

ok, I will take a look

@bmcgilli
Copy link
Contributor

bmcgilli commented Aug 4, 2023 •
edited
Loading

@darynaishchenko can you follow up on this? I think they are waiting for your response to check the test
@lazebnyi

@darynaishchenko darynaishchenko merged commit cc10df6 into airbytehq:master Aug 10, 2023
harrytou pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
@btkcodedev @archangelic
@darynaishchenko @harrytou
✨Source Zendesk Support: New Stream - Topics (airbytehq#27208)
abe32e4 
* Initial commit

* Update Docs

* Add expected records

* fixed tests

* fixed formatting

* fefactored topics stream

* updated abnormal_state.json

---------

Co-authored-by: Mal Hancock <mallory@archangelic.space>
Co-authored-by: Daryna Ishchenko <darina.ishchenko17@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darynaishchenko darynaishchenko darynaishchenko approved these changes

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/zendesk-support contributor-program PRs submitted through the contributor program. gl gl-review gl-review-needs-triage team/connectors-python
Projects
No open projects
Community Contributed PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Zendesk Support: new stream Topics
7 participants
@btkcodedev @darynaishchenko @bmcgilli @marcosmarxm @octavia-squidington-iii @jrolom @archangelic