-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 New Source : Avni #28141
🎉 New Source : Avni #28141
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. It would be better to implement this connector using low code connector.
airbyte-integrations/connectors/source-avni/source_avni/spec.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/schemas/subjects.json
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/source.py
Outdated
Show resolved
Hide resolved
@marcosmarxm can you review it now , I have made the changes you suggested. And Regarding low code we will do it later .... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments please take a look.
airbyte-integrations/connectors/source-avni/source_avni/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/source.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/spec.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/integration_tests/abnormal_state.json
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/source-avni/source_avni/source.py
Outdated
Show resolved
Hide resolved
9a349a1
to
d4edf43
Compare
@marcosmarxm Done suggested Changes Can you review it now? |
It looks good @avirajsingh7 can you share the output of integration tests? |
@marcosmarxm ![]() |
@marcosmarxm can you review it? |
Thanks for sharing the output @avirajsingh7 right now our team is responsible for the August Hackathon and all efforts are directed to review these contributions. After the event is done we're going to return to your contribution. |
Hello @avirajsingh7 thanks so much for your effort but the project is not accepting Python CDK sources anymore. This is a decision to improve maintenance and support. You can use the version for your project and if you want to contribute we recommend to move the connector to low-code/no-code framework. Hope you understand the decision, |
What
Describe what the change is solving
AVNI is an open source platform for on field service and data collection. A three-level adjustable data structure given by Avni enables modelling of the services offered (or data collected). Setting up topics, enrolling subjects in programmes, and establishing encounters for enrollments/subjects are all possible with Avni.
For organizations using Avni having a native Airbyte connector to import data will allow for ingestion into their data warehouses and use of the data for analysis.
It helps to add screenshots if it affects the frontend.
doesn't effect the frontend
How
Describe the solution
The current version of the connector provides for ingesting data through Airbyte from multiple streams . The implemented version of the connector will allow for all sync modes - full refresh and incremental including de-duped mode.
Avni Api Docs
Avni Api Endpoints
Pre-merge Actions
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.Connector version is set to
0.1.0
Dockerfile
has version0.1.0
Documentation updated
README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog with an entry for the initial version. See changelog exampledocs/integrations/README.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Updating a connector
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
Connector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit Test
Integration Test Connector
:Acceptance Test