Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Zendesk Support: Fix cursor pagination #28487

Merged
merged 8 commits into from
Jul 21, 2023
Merged

Source Zendesk Support: Fix cursor pagination #28487

merged 8 commits into from
Jul 21, 2023

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Jul 19, 2023 •
edited
Loading

What

Resolve https://github.com/airbytehq/oncall/issues/2530

How

  • Fix cursor pagination
  • Remove requests_futures implementation: using cursor can be done in sync mode only

Recommended reading order

  1. streams.py

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support labels Jul 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited by artem1205
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@artem1205 artem1205 marked this pull request as ready for review July 19, 2023 18:50
@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 2d6f0f7137) - ❌

⏲️ Total pipeline duration: 16mn21s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@clnoll
Copy link
Contributor

clnoll commented Jul 19, 2023

@artem1205 were you able to reproduce the issue locally? Can you add a unit test for this?

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 2d6f0f7137) - ❌

⏲️ Total pipeline duration: 16mn43s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
Connector version increment check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205 artem1205 marked this pull request as draft July 20, 2023 12:09
@artem1205 artem1205 marked this pull request as ready for review July 20, 2023 16:35
@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 945bea237d) - ❌

⏲️ Total pipeline duration: 02mn19s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 8f0881a03d) - ❌

⏲️ Total pipeline duration: 43mn08s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205 artem1205 changed the title Source Zendesk Support: Remove extra page from params Source Zendesk Support: Fix cursor pagination Jul 20, 2023
@artem1205 artem1205 self-assigned this Jul 20, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 0be8749fd4) - ❌

⏲️ Total pipeline duration: 43mn56s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit 65076c3a2d) - ❌

⏲️ Total pipeline duration: 49mn57s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit f5a3eb3181) - ❌

⏲️ Total pipeline duration: 44mn28s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@octavia-squidington-iii
Copy link
Collaborator

source-zendesk-support test report (commit b55468cc6e) - ✅

⏲️ Total pipeline duration: 12mn01s

Step Result
Validate airbyte-integrations/connectors/source-zendesk-support/metadata.yaml ✅
Connector version semver check ✅
QA checks ✅
Code format checks ✅
Connector package install ✅
Build source-zendesk-support docker image for platform linux/x86_64 ✅
Unit tests ✅
Acceptance tests ✅

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-zendesk-support test

@artem1205 artem1205 merged commit a7b5a9c into master Jul 21, 2023
@artem1205 artem1205 deleted the artem1205/source-zendesk-support-oc-2530 branch July 21, 2023 20:06
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
@artem1205 @efimmatytsin
Source Zendesk Support: Fix cursor pagination (airbytehq#28487)
f1ad300 
* Source Zendesk Support: Remove extra page from params

* Source Zendesk Support: bump version

* Source Zendesk Support: Refactor + Fix pagination issues

* Source Zendesk Support: fix object count

* Source Zendesk Support: update timeout for tests

* Source Zendesk Support: update expected_records

* Source Zendesk Support: update expected_records

* Source Zendesk Support: update ignore pagination
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

@darynaishchenko darynaishchenko Awaiting requested review from darynaishchenko

Assignees

@artem1205 artem1205

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artem1205 @octavia-squidington-iii @clnoll @lazebnyi