Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Greenhouse: fixed unittest #28597

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

darynaishchenko
Copy link
Collaborator

What

test_parse_response_expected_response failed due to incorrect comparison between dict and airbyte record types.

How

Added casting type from airbyte record type to dict in test for correct comparison.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@darynaishchenko darynaishchenko changed the title Source Greenhouse: fixed runittest Source Greenhouse: fixed unittest Jul 24, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-greenhouse test report (commit e196911b0b) - ✅

⏲️ Total pipeline duration: 07mn34s

Step Result
Validate airbyte-integrations/connectors/source-greenhouse/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-greenhouse docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-greenhouse test

@darynaishchenko darynaishchenko requested a review from lazebnyi July 24, 2023 09:21
@darynaishchenko darynaishchenko merged commit 00ac8f4 into master Jul 24, 2023
@darynaishchenko darynaishchenko deleted the daryna/source-greenhouse/fix-unettests branch July 24, 2023 10:59
efimmatytsin pushed a commit to scentbird/airbyte that referenced this pull request Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants