-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Shopify: improve error messages
, refactored code
#28700
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-shopify test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-shopify/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-shopify docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-shopify test
source-shopify test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-shopify/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-shopify docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-shopify test
What
Resolving:
How
AirbyteLogger
instances used before tologging.get_logger('airbyte')
to suppress the deprecation warningserror_mapping
forshould_retry
to clean up the code and handle the401, 402
HTTP errors causing the sync to fail once occurs instead of syncing the streamcheck_conenction
logic to the dedicatedConnectionCheckTest
class to have it all in 1 place to edit, once needed + improved the error handling.ShopifyAccessScopesError, ShopifyBadJsonError, ShopifyConnectionError, ShopifyNonRetryableErrors, ShopifyWrongShopNameError
to clean up the code and handle the errors caused by thecheck_connection / discovery
to crash silently with no error messages.expected_records
because thecustomer_saved_search
stream is not available for theairbyte-integration-test
but is available as a stream.🚨 User Impact 🚨
No impact is expected, this is not a breaking change.