Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Shopify: improve error messages, refactored code #28700

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

bazarnov
Copy link
Collaborator

What

Resolving:

How

  • refactored AirbyteLogger instances used before to logging.get_logger('airbyte') to suppress the deprecation warnings
  • refactored error_mapping for should_retry to clean up the code and handle the 401, 402 HTTP errors causing the sync to fail once occurs instead of syncing the stream
  • moved the check_conenction logic to the dedicated ConnectionCheckTest class to have it all in 1 place to edit, once needed + improved the error handling.
  • added /updated existing error classes ShopifyAccessScopesError, ShopifyBadJsonError, ShopifyConnectionError, ShopifyNonRetryableErrors, ShopifyWrongShopNameError to clean up the code and handle the errors caused by the check_connection / discovery to crash silently with no error messages.
  • updated expected_records because the customer_saved_search stream is not available for the airbyte-integration-test but is available as a stream.

🚨 User Impact 🚨

No impact is expected, this is not a breaking change.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 25, 2023
@bazarnov bazarnov marked this pull request as ready for review July 25, 2023 20:44
@bazarnov bazarnov self-assigned this Jul 25, 2023
@bazarnov bazarnov linked an issue Jul 25, 2023 that may be closed by this pull request
@octavia-squidington-iii
Copy link
Collaborator

source-shopify test report (commit c6e4ba9410) - ✅

⏲️ Total pipeline duration: 23mn57s

Step Result
Validate airbyte-integrations/connectors/source-shopify/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-shopify docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-shopify test

@octavia-squidington-iii
Copy link
Collaborator

source-shopify test report (commit c6e4ba9410) - ✅

⏲️ Total pipeline duration: 25mn13s

Step Result
Validate airbyte-integrations/connectors/source-shopify/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-shopify docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-shopify test

@bazarnov bazarnov merged commit 343a45c into master Jul 26, 2023
@bazarnov bazarnov deleted the baz/source-shopify-improve-error-messaging branch July 26, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/shopify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages for Shopify source
3 participants