Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source S3: encoding validation fix, refactor and test #28730

Merged
merged 4 commits into from
Jul 27, 2023

Conversation

roman-yermilov-gl
Copy link
Contributor

@roman-yermilov-gl roman-yermilov-gl commented Jul 26, 2023

What

A user gets a traceback in return If optional encoding field is not set. Instead of this we need to display a human readable error description

How

  • Fix an error with incorrect data type passed to codecs.lookup. None type is replaced with empty string
  • Fix error message. There was a problem with error_message varibale which is empty in cases when for loop validations is successfull
  • Fix version dependency conflict
  • Made small refactoring and unit test

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

Copy link
Collaborator

@davydov-d davydov-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump version in Dockerfile and metadata.yaml, also add a record in the changelog

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Jul 26, 2023
@roman-yermilov-gl roman-yermilov-gl force-pushed the ryermilov/source-s3-encoding-validation branch from 5d59db4 to f53727d Compare July 26, 2023 14:22
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review July 26, 2023 14:25
@octavia-squidington-iii
Copy link
Collaborator

source-s3 test report (commit 327b0fa50a) - ✅

⏲️ Total pipeline duration: 23mn22s

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@roman-yermilov-gl roman-yermilov-gl merged commit 9a714db into master Jul 27, 2023
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-s3-encoding-validation branch July 27, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants