-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors-ci: implement per step time out #28771
connectors-ci: implement per step time out #28771
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
This reverts commit 2f4fd39.
source-openweather test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-openweather/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-openweather docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather test
source-file test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-file/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-file test
/approve-and-merge reason="this PR unblocks the nightly build, I've thoroughly tested it, and my team is asleep and can't review" |
What
Closes #28769
Problem: Some infinitely hanging pipeline step can block other and make a full GHA workflow timeout.
Solution: Implement a per step timeout logic.
How
anyio.fail_after
featurerun_with_completion
to raiseTimeOutError
when the execution duration exceeds theStep.max_duration
value.Step
ConnectorPackageInstall(Step)
to preventpip
infinite dependency problems to timeout the GHA workflows.