Improve file identification for mypy #28780
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The current mypy script flags any file that is different from master. When there is a change to a file on master and you haven't merge master into your branch, it'll prevent you from merging even though there are no conflicts.
Here is an example where I was doing changes to the CATs but got a CI failure:
How
Concatenate the following commands:
git diff --name-only --relative ':(exclude)unit_tests'
: unstaged filesgit diff --name-only --staged --relative ':(exclude)unit_tests';
: staged filesgit diff --name-only master... --relative ':(exclude)unit_tests'; }
: commit filesAfter that, grep and filter out duplicates