Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File-based CDK: reorganize FileReadMode to fix circular import #28885

Merged
merged 1 commit into from
Jul 31, 2023
Merged

File-based CDK: reorganize FileReadMode to fix circular import #28885

merged 1 commit into from
Jul 31, 2023

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Jul 31, 2023

Move FileReadMode to file_based_stream_reader.py, which is where it's ultimately required. This fixes a circular import.

@clnoll clnoll requested review from a team and brianjlai July 31, 2023 21:48
@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Jul 31, 2023
brianjlai
brianjlai approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@clnoll clnoll merged commit 22ff7e0 into master Jul 31, 2023
@clnoll clnoll deleted the fix-filereadmode-circular-import branch July 31, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjlai brianjlai brianjlai approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clnoll @brianjlai @octavia-squidington-iii