Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors-ci] sentry: ignore error logs without exceptions #28897

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

pedroslopez
Copy link
Contributor

@pedroslopez pedroslopez commented Aug 1, 2023

What

We're getting a lot of logged errors that aren't actionable. We still want logger-based exception reporting though. This PR avoids sending error logs that don't have attached stacktraces.

How

Use sentry's before_send hook to filter out these logs.

@pedroslopez pedroslopez changed the title sentry: ignore error logs without exceptions [connectors-ci] sentry: ignore error logs without exceptions Aug 1, 2023
@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "pipelines"
version = "0.1.1"
version = "0.2.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: 0.2.0 wasn't bumped properly

@pedroslopez pedroslopez marked this pull request as ready for review August 1, 2023 02:16
@pedroslopez pedroslopez requested review from bnchrch and a team August 1, 2023 02:16
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@pedroslopez pedroslopez merged commit 6243ddc into master Aug 1, 2023
@pedroslopez pedroslopez deleted the pedroslopez/sentry-ignore-error-logs branch August 1, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants