Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public docs for typing & deduping #28902

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Add public docs for typing & deduping #28902

merged 4 commits into from
Aug 1, 2023

Conversation

Hesperide
Copy link
Contributor

@Hesperide Hesperide commented Aug 1, 2023 •
edited
Loading

  • Adds new 'Typing & Deduping' page describing the Destinations V2 launch and current set up while in early access.
    • When Destinations V2 is rolled out, the existing 'basic normalization' page will be retired.
    • We want users to refer to this functionality as 'Typing & Deduping' in the longer term, but to this launch as 'Destinations V2'
    • Setup instructions will be deleted prior to the full announcement.
  • Quick pass at updates to migration doc + adding some new assets.

@Hesperide Hesperide requested a review from evantahler August 1, 2023 06:43
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 1, 2023
@Hesperide Hesperide requested a review from cynthiaxyin August 1, 2023 06:44
@Hesperide Hesperide force-pushed the alex.cuoci/destinations-v2-public-docs branch from 5f516ed to 4a86784 Compare August 1, 2023 20:44
evantahler
evantahler approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Some suggestions, but nothing blocking

docs/understanding-airbyte/typing-deduping.md Outdated Show resolved Hide resolved
docs/understanding-airbyte/typing-deduping.md Outdated Show resolved Hide resolved
docs/understanding-airbyte/typing-deduping.md Outdated Show resolved Hide resolved
docs/understanding-airbyte/typing-deduping.md Outdated Show resolved Hide resolved
docs/understanding-airbyte/typing-deduping.md Outdated Show resolved Hide resolved
@Hesperide @evantahler
Apply suggestions from code review
1978d89 
Co-authored-by: Evan Tahler <evan@airbyte.io>
@Hesperide Hesperide merged commit 4de7801 into master Aug 1, 2023
@Hesperide Hesperide deleted the alex.cuoci/destinations-v2-public-docs branch August 1, 2023 22:06
bnchrch pushed a commit that referenced this pull request Aug 3, 2023
@Hesperide @evantahler @bnchrch
Add public docs for typing & deduping (#28902)
fc4119f 
* Add public docs for typing & deduping

* bugfix

* fixes

* Apply suggestions from code review

Co-authored-by: Evan Tahler <evan@airbyte.io>

---------

Co-authored-by: Evan Tahler <evan@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evantahler evantahler evantahler approved these changes

@cynthiaxyin cynthiaxyin Awaiting requested review from cynthiaxyin

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hesperide @evantahler @octavia-squidington-iii