Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Chargebee, Delighted: disabled Incremental tests #28905

Merged

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Aug 1, 2023

What

In order to maintain a good percentage of the connector-health report, some sources like Chargebee and Delighted stopped passing the incremental tests due to the errors in certain test methods of the CAT. Here is the related Slack thread: https://airbyte-globallogic.slack.com/archives/C02U9R3AF37/p1690810513681859

How

  • disabled the Incremental tests due to the inability to compare str and int values

🚨 User Impact 🚨

No impact is expected.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov marked this pull request as ready for review August 1, 2023 08:52
@octavia-squidington-iii
Copy link
Collaborator

source-chargebee test report (commit b9f182e43d) - ❌

⏲️ Total pipeline duration: 03mn17s

Step Result
Validate airbyte-integrations/connectors/source-chargebee/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-chargebee docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargebee test

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit b9f182e43d) - ❌

⏲️ Total pipeline duration: 03mn23s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit b9f182e43d) - ✅

⏲️ Total pipeline duration: 05mn11s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii
Copy link
Collaborator

source-chargebee test report (commit b9f182e43d) - ❌

⏲️ Total pipeline duration: 07mn13s

Step Result
Validate airbyte-integrations/connectors/source-chargebee/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-chargebee docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargebee test

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Aug 1, 2023
@bazarnov bazarnov requested review from lazebnyi and artem1205 August 1, 2023 09:10
@octavia-squidington-iii
Copy link
Collaborator

source-chargebee test report (commit d8a4f16a56) - ✅

⏲️ Total pipeline duration: 4.28s

Step Result

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargebee test

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit d8a4f16a56) - ❌

⏲️ Total pipeline duration: 02mn08s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii
Copy link
Collaborator

source-delighted test report (commit 58327400d0) - ✅

⏲️ Total pipeline duration: 04mn41s

Step Result
Validate airbyte-integrations/connectors/source-delighted/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-delighted docker image for platform linux/x86_64
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-delighted test

@octavia-squidington-iii
Copy link
Collaborator

source-chargebee test report (commit 58327400d0) - ✅

⏲️ Total pipeline duration: 06mn30s

Step Result
Validate airbyte-integrations/connectors/source-chargebee/metadata.yaml
Connector version semver check
Connector version increment check
QA checks
Code format checks
Connector package install
Build source-chargebee docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-chargebee test

@bazarnov bazarnov merged commit 3e466d7 into master Aug 1, 2023
@bazarnov bazarnov deleted the baz/source-chargebee-delighted-disable-incremental-cat branch August 1, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants