Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Monday, Harvest: update expected records #28908

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Aug 1, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@bazarnov bazarnov marked this pull request as ready for review August 1, 2023 10:13
@bazarnov bazarnov requested review from lazebnyi and artem1205 August 1, 2023 10:13
@octavia-squidington-iii
Copy link
Collaborator

source-monday test report (commit f1c6ddedb4) - ✅

⏲️ Total pipeline duration: 04mn51s

Step Result
Validate airbyte-integrations/connectors/source-monday/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-monday docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-monday test

@octavia-squidington-iii
Copy link
Collaborator

source-harvest test report (commit f1c6ddedb4) - ✅

⏲️ Total pipeline duration: 52mn49s

Step Result
Validate airbyte-integrations/connectors/source-harvest/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-harvest docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-harvest test

@bazarnov bazarnov merged commit 3a66dea into master Aug 1, 2023
@bazarnov bazarnov deleted the baz/source-monday-harvest-update-expected-recs branch August 1, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants