Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source MongoDB Internal POC: Discover Operation #28932

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

jdpgrailsdev
Copy link
Contributor

What

  • Add schema discovery to source

How

  • Implement schema discovery operation

Recommended reading order

  1. MongoDbSource.java
  2. MongoConnectionUtils.java
  3. MongoDbSourceAcceptanceTest.java
  4. spec.json

I have not yet created unit tests for the new code, but I did create an acceptance test that passes locally. I wanted to get this and the check implementation (coming next) in place to make it possible to use the connector in the platform. Once both of those are done, I will cycle back and do some refactoring and add more tests.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iii
Copy link
Collaborator

source-mongodb-internal-poc test report (commit ed1651e4ee) - ❌

⏲️ Total pipeline duration: 08mn01s

Step Result
Validate airbyte-integrations/connectors/source-mongodb-internal-poc/metadata.yaml
Connector version semver check
QA checks
Build connector tar
Build source-mongodb-internal-poc docker image for platform linux/x86_64
./gradlew :airbyte-integrations:connectors:source-mongodb-internal-poc:integrationTest
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-mongodb-internal-poc test

@jdpgrailsdev
Copy link
Contributor Author

/approve-and-merge reason="changes for mongodb source poc"

@octavia-approvington
Copy link
Contributor

What are we doing again?
merge and squash

@octavia-approvington octavia-approvington merged commit f204f7e into master Aug 1, 2023
@octavia-approvington octavia-approvington deleted the jonathan/mongodb-poc-discover branch August 1, 2023 20:00
bnchrch pushed a commit that referenced this pull request Aug 3, 2023
* Implement discover operation

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants