-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source MongoDB Internal POC: Discover Operation #28932
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-mongodb-internal-poc test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-mongodb-internal-poc/metadata.yaml | ✅ |
Connector version semver check | ✅ |
QA checks | ❌ |
Build connector tar | ✅ |
Build source-mongodb-internal-poc docker image for platform linux/x86_64 | ✅ |
./gradlew :airbyte-integrations:connectors:source-mongodb-internal-poc:integrationTest | ❌ |
Acceptance tests | ❌ |
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-mongodb-internal-poc test
/approve-and-merge reason="changes for mongodb source poc" |
* Implement discover operation * Formatting
What
How
Recommended reading order
MongoDbSource.java
MongoConnectionUtils.java
MongoDbSourceAcceptanceTest.java
spec.json
I have not yet created unit tests for the new code, but I did create an acceptance test that passes locally. I wanted to get this and the check implementation (coming next) in place to make it possible to use the connector in the platform. Once both of those are done, I will cycle back and do some refactoring and add more tests.