Use full enquoted table name for max cursor query #28954

rodireich · 2023-08-01T22:35:04Z

What

Fix max cursor query for tables containing capital letters.

github-actions · 2023-08-01T22:35:26Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

octavia-squidington-iii · 2023-08-01T22:46:15Z

source-alloydb test report (commit `dbfece1706`) - ❌

⏲️ Total pipeline duration: 09mn03s

Step	Result
Validate airbyte-integrations/connectors/source-alloydb/metadata.yaml	✅
Connector version semver check	✅
QA checks	✅
Build connector tar	✅
Build source-alloydb docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-alloydb:integrationTest	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb test

github-actions · 2023-08-01T23:01:14Z

Coverage report for source-postgres

File	Coverage [86.44%]	🍏
PostgresSource.java	87.71%	🍏
PostgresQueryUtils.java	82.93%	🍏

Total Project Coverage	70.3%	🍏

…exception-error-relation-roboadvicescores-does-not-exist-via-sentry

nguyenaiden

+1. Maybe worth it for us to start using the ORM like Hibernate instead of raw SQL, especially if we're writing queries that aren't too complex.

rodireich · 2023-08-01T23:59:38Z

/legacy-test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5733031857
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/5733031857
No Python unittests run

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: not found in the config.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:105: The previous and actual specifications are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:628: The previous and actual discovered catalogs are identical.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/connector_acceptance_test/tests/test_core.py:725: This tests currently leads to too much failures. We need to fix the connectors at scale first.
================== 70 passed, 7 skipped in 108.72s (0:01:48) ===================

rodireich · 2023-08-01T23:59:50Z

/legacy-test connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/5733032829
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/5733032829
No Python unittests run

Build Passed

Test summary info:

All Passed

rodireich · 2023-08-02T01:11:02Z

/approve-and-merge reason="tests passing. ci seems broken"

octavia-approvington · 2023-08-02T01:11:38Z

Jerry would be proud

octavia-squidington-iii · 2023-08-02T03:53:52Z

source-postgres test report (commit `dbfece1706`) - ❌

⏲️ Total pipeline duration: 307mn24s

Step	Result
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-postgres:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

octavia-squidington-iii · 2023-08-02T04:04:21Z

source-postgres-strict-encrypt test report (commit `dbfece1706`) - ❌

⏲️ Total pipeline duration: 10mn14s

Step	Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml	✅
Connector version semver check	❌
QA checks	❌
Build connector tar	✅
Build source-postgres-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-postgres-strict-encrypt:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

octavia-squidington-iii · 2023-08-02T04:14:13Z

source-alloydb-strict-encrypt test report (commit `dbfece1706`) - ❌

⏲️ Total pipeline duration: 09mn19s

Step	Result
Validate airbyte-integrations/connectors/source-alloydb-strict-encrypt/metadata.yaml	✅
Connector version semver check	❌
QA checks	✅
Build connector tar	✅
Build source-alloydb-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-alloydb-strict-encrypt:integrationTest	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb-strict-encrypt test

octavia-squidington-iii · 2023-08-02T04:32:14Z

source-alloydb-strict-encrypt test report (commit `8b65c4268d`) - ❌

⏲️ Total pipeline duration: 08mn47s

Step	Result
Validate airbyte-integrations/connectors/source-alloydb-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Build connector tar	✅
Build source-alloydb-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-alloydb-strict-encrypt:integrationTest	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb-strict-encrypt test

octavia-squidington-iii · 2023-08-02T04:40:46Z

source-alloydb test report (commit `8b65c4268d`) - ❌

⏲️ Total pipeline duration: 08mn19s

Step	Result
Validate airbyte-integrations/connectors/source-alloydb/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Build connector tar	✅
Build source-alloydb docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-alloydb:integrationTest	✅
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-alloydb test

octavia-squidington-iii · 2023-08-02T04:51:08Z

source-postgres-strict-encrypt test report (commit `8b65c4268d`) - ❌

⏲️ Total pipeline duration: 10mn09s

Step	Result
Validate airbyte-integrations/connectors/source-postgres-strict-encrypt/metadata.yaml	✅
Connector version semver check	✅
QA checks	❌
Build connector tar	✅
Build source-postgres-strict-encrypt docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-postgres-strict-encrypt:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres-strict-encrypt test

octavia-squidington-iii · 2023-08-02T09:58:44Z

source-postgres test report (commit `8b65c4268d`) - ❌

⏲️ Total pipeline duration: 307mn21s

Step	Result
Validate airbyte-integrations/connectors/source-postgres/metadata.yaml	✅
Connector version semver check	✅
Connector version increment check	❌
QA checks	❌
Build connector tar	✅
Build source-postgres docker image for platform linux/x86_64	✅
./gradlew :airbyte-integrations:connectors:source-postgres:integrationTest	❌
Acceptance tests	❌

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-postgres test

* Use full enquoted table name for max cursor query * Bump versions

Use full enquoted table name for max cursor query

dbfece1

rodireich requested a review from a team as a code owner August 1, 2023 22:35

octavia-squidington-iii added area/connectors Connector related issues connectors/source/postgres labels Aug 1, 2023

prateekmukhedkar approved these changes Aug 1, 2023

View reviewed changes

rodireich added 2 commits August 1, 2023 16:16

Bump versions

85bb04f

Merge branch 'master' into 2603-source-postgres-orgpostgresqlutilpsql…

416c3cd

…exception-error-relation-roboadvicescores-does-not-exist-via-sentry

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/source/postgres-strict-encrypt connectors/source/alloydb connectors/source/alloydb-strict-encrypt labels Aug 1, 2023

nguyenaiden approved these changes Aug 1, 2023

View reviewed changes

octavia-approvington approved these changes Aug 2, 2023

View reviewed changes

octavia-approvington merged commit 3365015 into master Aug 2, 2023

octavia-approvington deleted the 2603-source-postgres-orgpostgresqlutilpsqlexception-error-relation-roboadvicescores-does-not-exist-via-sentry branch August 2, 2023 01:11

bnchrch pushed a commit that referenced this pull request Aug 3, 2023

Use full enquoted table name for max cursor query (#28954)

d409393

* Use full enquoted table name for max cursor query * Bump versions

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use full enquoted table name for max cursor query #28954

Use full enquoted table name for max cursor query #28954

rodireich commented Aug 1, 2023

github-actions bot commented Aug 1, 2023

octavia-squidington-iii commented Aug 1, 2023

github-actions bot commented Aug 1, 2023 •

edited

Loading

nguyenaiden left a comment

rodireich commented Aug 1, 2023 •

edited by github-actions bot

Loading

rodireich commented Aug 1, 2023 •

edited by github-actions bot

Loading

rodireich commented Aug 2, 2023

octavia-approvington commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

Use full enquoted table name for max cursor query #28954

Use full enquoted table name for max cursor query #28954

Conversation

rodireich commented Aug 1, 2023

What

github-actions bot commented Aug 1, 2023

Before Merging a Connector Pull Request

octavia-squidington-iii commented Aug 1, 2023

source-alloydb test report (commit dbfece1706) - ❌

github-actions bot commented Aug 1, 2023 • edited Loading

Coverage report for source-postgres

nguyenaiden left a comment

Choose a reason for hiding this comment

rodireich commented Aug 1, 2023 • edited by github-actions bot Loading

Build Passed

rodireich commented Aug 1, 2023 • edited by github-actions bot Loading

Build Passed

rodireich commented Aug 2, 2023

octavia-approvington commented Aug 2, 2023

octavia-squidington-iii commented Aug 2, 2023

source-postgres test report (commit dbfece1706) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-postgres-strict-encrypt test report (commit dbfece1706) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-alloydb-strict-encrypt test report (commit dbfece1706) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-alloydb-strict-encrypt test report (commit 8b65c4268d) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-alloydb test report (commit 8b65c4268d) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-postgres-strict-encrypt test report (commit 8b65c4268d) - ❌

octavia-squidington-iii commented Aug 2, 2023

source-postgres test report (commit 8b65c4268d) - ❌

source-alloydb test report (commit `dbfece1706`) - ❌

github-actions bot commented Aug 1, 2023 •

edited

Loading

rodireich commented Aug 1, 2023 •

edited by github-actions bot

Loading

rodireich commented Aug 1, 2023 •

edited by github-actions bot

Loading

source-postgres test report (commit `dbfece1706`) - ❌

source-postgres-strict-encrypt test report (commit `dbfece1706`) - ❌

source-alloydb-strict-encrypt test report (commit `dbfece1706`) - ❌

source-alloydb-strict-encrypt test report (commit `8b65c4268d`) - ❌

source-alloydb test report (commit `8b65c4268d`) - ❌

source-postgres-strict-encrypt test report (commit `8b65c4268d`) - ❌

source-postgres test report (commit `8b65c4268d`) - ❌