Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions for mssql strict-encrypt #28964

Merged
merged 6 commits into from
Aug 3, 2023
Merged

Bump versions for mssql strict-encrypt #28964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9de8dfb
Bump versions for mssql strict-encrypt
rodireich Aug 2, 2023
5d40cdf
Merge branch 'master' into 28543-publish-source-mssql-strict-encrypt
rodireich Aug 2, 2023
dc2aa72
Merge branch 'master' into 28543-publish-source-mssql-strict-encrypt
rodireich Aug 3, 2023
86b1f20
Merge branch 'master' into 28543-publish-source-mssql-strict-encrypt
rodireich Aug 3, 2023
668714e
Fix failing test
rodireich Aug 3, 2023
72e3286
Fix failing test
rodireich Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mssql-strict-encrypt/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ ENV APPLICATION source-mssql-strict-encrypt

COPY --from=build /airbyte /airbyte

LABEL io.airbyte.version=1.1.0
LABEL io.airbyte.version=1.1.1
LABEL io.airbyte.name=airbyte/source-mssql-strict-encrypt
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mssql-strict-encrypt/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: b5ea17b1-f170-46dc-bc31-cc744ca984c1
dockerImageTag: 1.1.0
dockerImageTag: 1.1.1
dockerRepository: airbyte/source-mssql-strict-encrypt
githubIssueLabel: source-mssql
icon: mssql.svg
Expand Down
6 changes: 3 additions & 3 deletions ...s/source-mssql/src/test/java/io/airbyte/integrations/source/mssql/CdcMssqlSourceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public String createSchemaQuery(final String schemaName) {

// TODO : Delete this Override when MSSQL supports individual table snapshot
@Override
public void newTableSnapshotTest() throws Exception {
public void newTableSnapshotTest() {
// Do nothing
}

Expand Down Expand Up @@ -314,7 +314,7 @@ void testAssertSnapshotIsolationDisabled() {
// set snapshot_isolation level to "Read Committed" to disable snapshot
.put("snapshot_isolation", "Read Committed")
.build());
Jsons.replaceNestedValue(config, List.of("replication"), replicationConfig);
Jsons.replaceNestedValue(config, List.of("replication_method"), replicationConfig);
assertDoesNotThrow(() -> source.assertSnapshotIsolationAllowed(config, testJdbcDatabase));
switchSnapshotIsolation(false, dbName);
assertDoesNotThrow(() -> source.assertSnapshotIsolationAllowed(config, testJdbcDatabase));
Expand Down Expand Up @@ -350,7 +350,7 @@ void testCdcCheckOperations() throws Exception {
void testCdcCheckOperationsWithDot() throws Exception {
// assertCdcEnabledInDb and validate escape with special character
switchCdcOnDatabase(true, dbNamewithDot);
AirbyteConnectionStatus status = getSource().check(getConfig());
final AirbyteConnectionStatus status = getSource().check(getConfig());
assertEquals(status.getStatus(), AirbyteConnectionStatus.Status.SUCCEEDED);
}

Expand Down