Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p0-stripe-object-nodes-23-08-02 - revert stripe to 3.17.1 #29004

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Aug 2, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@clnoll clnoll requested a review from maxi297 August 2, 2023 17:38
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@clnoll clnoll enabled auto-merge (squash) August 2, 2023 17:53
@clnoll
Copy link
Contributor Author

clnoll commented Aug 2, 2023

/approve-and-merge reason="p0-stripe-object-nodes-23-08-02"

@clnoll clnoll disabled auto-merge August 2, 2023 19:24
@clnoll clnoll enabled auto-merge (squash) August 2, 2023 19:24
@octavia-approvington
Copy link
Contributor

Send it!
rocket socks

@octavia-approvington octavia-approvington merged commit 2a62e5e into master Aug 2, 2023
@octavia-approvington octavia-approvington deleted the stripe-p0-revert-cloud branch August 2, 2023 19:24
@lazebnyi lazebnyi changed the title p0-stripe-object-nodes-23-08-02 - revert stripe to 3.15.0 p0-stripe-object-nodes-23-08-02 - revert stripe to 3.17.1 Aug 2, 2023
@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit 8bde78ef45) - ✅

⏲️ Total pipeline duration: 09mn48s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

@octavia-squidington-iii
Copy link
Collaborator

source-stripe test report (commit bbdce4664a) - ✅

⏲️ Total pipeline duration: 09mn31s

Step Result
Validate airbyte-integrations/connectors/source-stripe/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-stripe docker image for platform linux/x86_64
Unit tests
Acceptance tests

🔗 View the logs here

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-stripe test

bnchrch pushed a commit that referenced this pull request Aug 3, 2023
* p0-stripe-object-nodes-23-08-02 - revert stripe to 3.15.0

* Revert to 3.17.1 instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants