HOTFIX: Ensure we use the alias when exporting #29010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve-and-merge reason="prepublish fix" |
|
Myomoto says it looks good |
octavia-approvington
approved these changes
Aug 2, 2023
bnchrch
added a commit
that referenced
this pull request
Aug 3, 2023
* Ensure we use the alias when exporting * bump lock file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Pydantic doesnt handle fields that start with a _ well and instead chooses to
field_abcfield name as an aliasThis is a problem when converted back to json or a dict as it prefers to use the
field_definition and not the aliasNote for reviewer
Im quickly merging in this fix to unblock a P0 and introducing a much more thorough PR right after