-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source Facebook-Marketing: fix broken OAuth
references in spec
#29042
🐛 Source Facebook-Marketing: fix broken OAuth
references in spec
#29042
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
This comment was marked as outdated.
This comment was marked as outdated.
source-facebook-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-facebook-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-facebook-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Integration tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-facebook-marketing test
What
Based on this CAT test: https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci-internal/connectors/test/nightly_builds/master/1691021930/3af7f3b6fbde9702a8d9c08fbd3f71d304508e98/source-facebook-marketing/1.1.1/output.html
Need to fix the broken
advancedAuth
references forcomplete_oauth_server_output
How
client_id
,client_secret
to thespec.py
integration_tests/spec.json
with spec duplicate🚨 User Impact 🚨
No impact is expected. Not a breaking change.