Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source S3: add defaults to file types to fix spec CATs #29065

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

clnoll
Copy link
Contributor

@clnoll clnoll commented Aug 3, 2023

What

Fixes the spec CAT by adding a default key to the expected output (in spec.json).

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@clnoll clnoll requested review from bazarnov and brianjlai August 3, 2023 20:15
@clnoll
Copy link
Contributor Author

clnoll commented Aug 3, 2023

@bazarnov I'm not sure why this test started failing suddenly when the same version had just passed. Did we upgrade airbyte-cdk's pydantic version recently? At any rate this should fix it.

cc @brianjlai - this PR is related to the old spec, but since it follows the pattern of the v4 spec that you've been involved with I thought you might have some insight into it.

@octavia-squidington-iii
Copy link
Collaborator

source-s3 test report (commit e022a7070f) - ✅

⏲️ Total pipeline duration: 17mn22s

Step Result
Validate airbyte-integrations/connectors/source-s3/metadata.yaml
Connector version semver check
QA checks
Code format checks
Connector package install
Build source-s3 docker image for platform linux/x86_64
Unit tests
Integration tests
Acceptance tests

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-s3 test

@clnoll clnoll merged commit 694e883 into master Aug 4, 2023
@clnoll clnoll deleted the source-s3-fix-spec-cat branch August 4, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants