connectors-ci: auto retry on DaggerError
#29081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
|
| Step | Result |
|---|---|
| Validate airbyte-integrations/connectors/source-openweather/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| QA checks | ✅ |
| Code format checks | ✅ |
| Connector package install | ✅ |
| Build source-openweather docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-openweather test
|
Manual testing:
|
This reverts commit daec730.
evantahler
approved these changes
Aug 4, 2023
| @@ -91,13 +91,16 @@ class Step(ABC): | |||
|
|
|||
| title: ClassVar[str] | |||
| max_retries: ClassVar[int] = 0 | |||
| max_dagger_error_retries: ClassVar[int] = 3 | |||
There was a problem hiding this comment.
3 retries - the classic starting place
| should_log: ClassVar[bool] = True | ||
| success_exit_code: ClassVar[int] = 0 | ||
| skipped_exit_code: ClassVar[int] = None | ||
| # The max duration of a step run. If the step run for more than this duration it will be considered as timed out. | ||
| # The default of 5 hours is arbitrary and can be changed if needed. | ||
| max_duration: ClassVar[timedelta] = timedelta(hours=5) | ||
|
|
||
| retry_delay = timedelta(seconds=10) |
There was a problem hiding this comment.
I like how we can configure this as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #28796
Our pipeline might occasionally face transient DaggerError (eg failure reaching out to DockerHub).
To avoid pipeline flakyness we can retry a step run on this type of failure
How
max_dagger_error_retriesattribute onStepwhich defaults to 3