-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source TikTok Marketing: add missing property to ad_groups
schema, fix None > null
in expected records
#29083
🐛 Source TikTok Marketing: add missing property to ad_groups
schema, fix None > null
in expected records
#29083
Conversation
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
source-tiktok-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-tiktok-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tiktok-marketing test
source-tiktok-marketing test report (commit
|
Step | Result |
---|---|
Validate airbyte-integrations/connectors/source-tiktok-marketing/metadata.yaml | ✅ |
Connector version semver check | ✅ |
Connector version increment check | ✅ |
QA checks | ✅ |
Code format checks | ✅ |
Connector package install | ✅ |
Build source-tiktok-marketing docker image for platform linux/x86_64 | ✅ |
Unit tests | ✅ |
Acceptance tests | ✅ |
☁️ View runs for commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-tiktok-marketing test
What
Based on this CAT test: https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci-internal/connectors/test/nightly_builds/master/1691021930/3af7f3b6fbde9702a8d9c08fbd3f71d304508e98/source-tiktok-marketing/3.4.0/output.html
The
expected records
containsNone
in JSON structure, which is not permitted by JSON notation, we should usenull
instead.How
expected records
for all streamsunexpected schema property
to thead_groups
stream schema🚨 User Impact 🚨
Non-breaking change, no impact is expected.