Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update to use new slack op #29100

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

bnchrch
Copy link
Contributor

@bnchrch bnchrch commented Aug 4, 2023

overview

Slack webhook method was broken, likely due to a subtle version mismatch behind the scenes.

the solution here is to just use our new method.

🤠 Merging it because a report is currently broken

@bnchrch bnchrch force-pushed the bnchrch/dagster/update-slack-method branch from 998cb5b to f687fb8 Compare August 4, 2023 19:13
@bnchrch
Copy link
Contributor Author

bnchrch commented Aug 4, 2023

/approve-and-merge reason="fix ci report"

@octavia-approvington
Copy link
Contributor

This looks fine!
Merged!
Imagine it being fine

@octavia-approvington octavia-approvington merged commit f854690 into master Aug 4, 2023
@octavia-approvington octavia-approvington deleted the bnchrch/dagster/update-slack-method branch August 4, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants